Improve security by eliminating the use of well-known names. #9026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to test this still, but would also like others to give this a try to make sure it works on every OS. |
fauxpark
approved these changes
May 5, 2020
ridingqwerty
approved these changes
May 6, 2020
zvecr
requested changes
May 6, 2020
Co-authored-by: Joel Challis <[email protected]>
zvecr
approved these changes
May 7, 2020
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
…s. (qmk#9026) * Improve security by eliminating the use of well-known names. * Add an additional $ so the shell expands $TMP1 and $TMP2 Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 24, 2020
…s. (qmk#9026) * Improve security by eliminating the use of well-known names. * Add an additional $ so the shell expands $TMP1 and $TMP2 Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
…s. (qmk#9026) * Improve security by eliminating the use of well-known names. * Add an additional $ so the shell expands $TMP1 and $TMP2 Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 12, 2020
…s. (qmk#9026) * Improve security by eliminating the use of well-known names. * Add an additional $ so the shell expands $TMP1 and $TMP2 Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
…s. (qmk#9026) * Improve security by eliminating the use of well-known names. * Add an additional $ so the shell expands $TMP1 and $TMP2 Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
…s. (qmk#9026) * Improve security by eliminating the use of well-known names. * Add an additional $ so the shell expands $TMP1 and $TMP2 Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
…s. (qmk#9026) * Improve security by eliminating the use of well-known names. * Add an additional $ so the shell expands $TMP1 and $TMP2 Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…s. (qmk#9026) * Improve security by eliminating the use of well-known names. * Add an additional $ so the shell expands $TMP1 and $TMP2 Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using predictable names for temp files is not a good idea. While it's unlikely someone will write an exploit for this we should still be safe.
As a side benefit, in the unlikely situation that 2 users use QMK on the same machine they'll still be able to flash avrdude boards. This could be beneficial in a lab environment.
Types of Changes
Checklist