Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BDN9 rev2 #9017

Merged
merged 13 commits into from
Jun 10, 2020
Merged

Add BDN9 rev2 #9017

merged 13 commits into from
Jun 10, 2020

Conversation

nooges
Copy link
Member

@nooges nooges commented May 4, 2020

Description

  • Add BDN9 Rev. 2.
  • Add test keymap

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team May 15, 2020 19:48
@zvecr zvecr added the breaking_change Changes that need to wait for a version increment label May 15, 2020
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added breaking changes due to user keymaps changed @xplusplus @bcat, and also no use of DEFAULT_FOLDER.

@drashna drashna requested a review from a team May 19, 2020 10:20
@nooges
Copy link
Member Author

nooges commented May 26, 2020

Added in default folder

@nooges nooges requested a review from zvecr May 26, 2020 21:52
@nooges nooges merged commit 184c362 into qmk:master Jun 10, 2020
@nooges nooges deleted the bdn9-rev2 branch June 10, 2020 02:32
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@nblyumberg nblyumberg mentioned this pull request Dec 31, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment keyboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants