fix sick68 space key handwiring location #8962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also fixed @mechmerlin's layout, apparently there was an extra comma. Hope it's ok. 😄 |
zvecr
requested changes
Apr 28, 2020
Co-Authored-By: Joel Challis <[email protected]>
fauxpark
approved these changes
Apr 28, 2020
zvecr
reviewed
Apr 28, 2020
zvecr
approved these changes
Apr 28, 2020
mrlinuxfish
pushed a commit
to mrlinuxfish/qmk_firmware
that referenced
this pull request
May 3, 2020
* fix space key handwiring location * fix mechmerlin layout * Revert changes from mechmerlin layout Co-Authored-By: Joel Challis <[email protected]> * Update layouts/community/65_ansi/mechmerlin/keymap.c * revert Co-authored-by: Joel Challis <[email protected]>
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
* fix space key handwiring location * fix mechmerlin layout * Revert changes from mechmerlin layout Co-Authored-By: Joel Challis <[email protected]> * Update layouts/community/65_ansi/mechmerlin/keymap.c * revert Co-authored-by: Joel Challis <[email protected]>
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
* fix space key handwiring location * fix mechmerlin layout * Revert changes from mechmerlin layout Co-Authored-By: Joel Challis <[email protected]> * Update layouts/community/65_ansi/mechmerlin/keymap.c * revert Co-authored-by: Joel Challis <[email protected]>
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
* fix space key handwiring location * fix mechmerlin layout * Revert changes from mechmerlin layout Co-Authored-By: Joel Challis <[email protected]> * Update layouts/community/65_ansi/mechmerlin/keymap.c * revert Co-authored-by: Joel Challis <[email protected]>
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* fix space key handwiring location * fix mechmerlin layout * Revert changes from mechmerlin layout Co-Authored-By: Joel Challis <[email protected]> * Update layouts/community/65_ansi/mechmerlin/keymap.c * revert Co-authored-by: Joel Challis <[email protected]>
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
* fix space key handwiring location * fix mechmerlin layout * Revert changes from mechmerlin layout Co-Authored-By: Joel Challis <[email protected]> * Update layouts/community/65_ansi/mechmerlin/keymap.c * revert Co-authored-by: Joel Challis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sick68 space key handwiring location
Description
This PR will fix an error I made. The space switch location according to the documentation I linked is different from the one used in
sick68.h.Types of Changes
Issues Fixed or Closed by This PR
Checklist