Add Funky40 support #8942
Merged
Add Funky40 support #8942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should add all proper files for the funky40 a keyboard I designed for myself, /u/TheFourthcow, a 40% ortholinear with split spacebar.
…l reccomended changes from my previous pull request
…ide with no errors hopefully this one works!
|
You do not need to keep opening new PRs. Just commit and push to the same branch and the original PR will be updated. If you've accepted suggestions on the PR, you will need to pull those changes to your local copy first. |
fauxpark
requested changes
Apr 27, 2020
13 tasks
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Ryan <[email protected]>
ridingqwerty
requested changes
Apr 27, 2020
noroadsleft
requested changes
Apr 27, 2020
fauxpark
approved these changes
Apr 27, 2020
|
Just missing an info.json. |
|
Thanks! I'll get the |
|
do I need to get the |
@TheFourthCow If you want to do it yourself, here's how. If you need any help just ping me on this PR or a new one. I'm also on QMK Discord, with this same username. |
mrlinuxfish
pushed a commit
to mrlinuxfish/qmk_firmware
that referenced
this pull request
May 3, 2020
* Adding all relevant files for the Funky40 This should add all proper files for the funky40 a keyboard I designed for myself, /u/TheFourthcow, a 40% ortholinear with split spacebar. * Second attempt to add all relevant files for the funky40, includes all reccomended changes from my previous pull request * Revised most files for Funky40 including reccomenations from my previous pull request * further modifications made to default funky40 board, compiles on my side with no errors hopefully this one works! * Update keyboards/funky40/readme.mk.mk * Update keyboards/funky40/keymaps/default/readme.md.md * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/config.h * updating readmes and keymap * final update to keymap and readmes should function correctly with updates requested * made changes as requested by noroadsleft to config and readme
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
* Adding all relevant files for the Funky40 This should add all proper files for the funky40 a keyboard I designed for myself, /u/TheFourthcow, a 40% ortholinear with split spacebar. * Second attempt to add all relevant files for the funky40, includes all reccomended changes from my previous pull request * Revised most files for Funky40 including reccomenations from my previous pull request * further modifications made to default funky40 board, compiles on my side with no errors hopefully this one works! * Update keyboards/funky40/readme.mk.mk * Update keyboards/funky40/keymaps/default/readme.md.md * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/config.h * updating readmes and keymap * final update to keymap and readmes should function correctly with updates requested * made changes as requested by noroadsleft to config and readme
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
* Adding all relevant files for the Funky40 This should add all proper files for the funky40 a keyboard I designed for myself, /u/TheFourthcow, a 40% ortholinear with split spacebar. * Second attempt to add all relevant files for the funky40, includes all reccomended changes from my previous pull request * Revised most files for Funky40 including reccomenations from my previous pull request * further modifications made to default funky40 board, compiles on my side with no errors hopefully this one works! * Update keyboards/funky40/readme.mk.mk * Update keyboards/funky40/keymaps/default/readme.md.md * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/config.h * updating readmes and keymap * final update to keymap and readmes should function correctly with updates requested * made changes as requested by noroadsleft to config and readme
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
* Adding all relevant files for the Funky40 This should add all proper files for the funky40 a keyboard I designed for myself, /u/TheFourthcow, a 40% ortholinear with split spacebar. * Second attempt to add all relevant files for the funky40, includes all reccomended changes from my previous pull request * Revised most files for Funky40 including reccomenations from my previous pull request * further modifications made to default funky40 board, compiles on my side with no errors hopefully this one works! * Update keyboards/funky40/readme.mk.mk * Update keyboards/funky40/keymaps/default/readme.md.md * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/config.h * updating readmes and keymap * final update to keymap and readmes should function correctly with updates requested * made changes as requested by noroadsleft to config and readme
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* Adding all relevant files for the Funky40 This should add all proper files for the funky40 a keyboard I designed for myself, /u/TheFourthcow, a 40% ortholinear with split spacebar. * Second attempt to add all relevant files for the funky40, includes all reccomended changes from my previous pull request * Revised most files for Funky40 including reccomenations from my previous pull request * further modifications made to default funky40 board, compiles on my side with no errors hopefully this one works! * Update keyboards/funky40/readme.mk.mk * Update keyboards/funky40/keymaps/default/readme.md.md * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/config.h * updating readmes and keymap * final update to keymap and readmes should function correctly with updates requested * made changes as requested by noroadsleft to config and readme
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
* Adding all relevant files for the Funky40 This should add all proper files for the funky40 a keyboard I designed for myself, /u/TheFourthcow, a 40% ortholinear with split spacebar. * Second attempt to add all relevant files for the funky40, includes all reccomended changes from my previous pull request * Revised most files for Funky40 including reccomenations from my previous pull request * further modifications made to default funky40 board, compiles on my side with no errors hopefully this one works! * Update keyboards/funky40/readme.mk.mk * Update keyboards/funky40/keymaps/default/readme.md.md * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/keymaps/default/keymap.c * Update keyboards/funky40/config.h * updating readmes and keymap * final update to keymap and readmes should function correctly with updates requested * made changes as requested by noroadsleft to config and readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding files for the Funky40 a new board from /u/TheFourthCow.
Edited code to ensure compilation is successful, removed a recommendation from a previous pull request as the changing of #include "funky40.h" to what was recommended resulted in many errors, unsure of what to do if this does not compile correctly when this is submitted, will seek assistance in the discord tomorrow. Thanks again!
convinced keymap.c and funky40.h to work with KEYMAP changed to LAYOUT as requested.
Checklist