Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add personal layout: dz60:mpstewart #8938

Merged
merged 6 commits into from
Apr 27, 2020
Merged

Conversation

mpstewart
Copy link
Contributor

This pull request adds my personal layout for the DZ60.

keyboards/dz60/keymaps/mpstewart/keymap.c Outdated Show resolved Hide resolved
keyboards/dz60/keymaps/mpstewart/keymap.c Outdated Show resolved Hide resolved
keyboards/dz60/keymaps/mpstewart/keymap.c Outdated Show resolved Hide resolved
keyboards/dz60/keymaps/mpstewart/keymap.c Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team April 27, 2020 02:45
@mpstewart
Copy link
Contributor Author

@fauxpark,
Thank you for the suggestions. For my own edification, are macro aliases generally frowned upon in this project for new keymaps?

@fauxpark
Copy link
Member

fauxpark commented Apr 27, 2020

Those ones were, since there's no point to them - QMK already has 7-character short aliases for those keycodes, which are there specifically so you can align your keymap for readability. The C_ESC one is fine though, as the full keycode is too long for that.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit dd60fcd into qmk:master Apr 27, 2020
@noroadsleft
Copy link
Member

Thanks!

mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
* mpstewart dz60 layout

* Remove macro aliases from keymap

* Remove macro aliases from keymap

* Update keyboards/dz60/keymaps/mpstewart/keymap.c

* Remove macro aliases from keymap

* use AG_TOGG instead of AG_SWAP

Also some commentary changes, and a change to one of the layout graphics
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
* mpstewart dz60 layout

* Remove macro aliases from keymap

* Remove macro aliases from keymap

* Update keyboards/dz60/keymaps/mpstewart/keymap.c

* Remove macro aliases from keymap

* use AG_TOGG instead of AG_SWAP

Also some commentary changes, and a change to one of the layout graphics
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* mpstewart dz60 layout

* Remove macro aliases from keymap

* Remove macro aliases from keymap

* Update keyboards/dz60/keymaps/mpstewart/keymap.c

* Remove macro aliases from keymap

* use AG_TOGG instead of AG_SWAP

Also some commentary changes, and a change to one of the layout graphics
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* mpstewart dz60 layout

* Remove macro aliases from keymap

* Remove macro aliases from keymap

* Update keyboards/dz60/keymaps/mpstewart/keymap.c

* Remove macro aliases from keymap

* use AG_TOGG instead of AG_SWAP

Also some commentary changes, and a change to one of the layout graphics
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* mpstewart dz60 layout

* Remove macro aliases from keymap

* Remove macro aliases from keymap

* Update keyboards/dz60/keymaps/mpstewart/keymap.c

* Remove macro aliases from keymap

* use AG_TOGG instead of AG_SWAP

Also some commentary changes, and a change to one of the layout graphics
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* mpstewart dz60 layout

* Remove macro aliases from keymap

* Remove macro aliases from keymap

* Update keyboards/dz60/keymaps/mpstewart/keymap.c

* Remove macro aliases from keymap

* use AG_TOGG instead of AG_SWAP

Also some commentary changes, and a change to one of the layout graphics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants