Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add via support for cypher rev5 PCB #8898

Merged
merged 4 commits into from
Apr 29, 2020
Merged

[Keyboard] Add via support for cypher rev5 PCB #8898

merged 4 commits into from
Apr 29, 2020

Conversation

yd-null
Copy link
Contributor

@yd-null yd-null commented Apr 24, 2020

Description

Add via support for cypher rev5 PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@yd-null yd-null mentioned this pull request Apr 24, 2020
Merged
6 tasks
zvecr
zvecr requested changes Apr 24, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyboards/westfoxtrot/cypher/rev5/via needs to be moved to keyboards/westfoxtrot/cypher/rev5/keymaps/via

@zvecr zvecr added the keymap label Apr 24, 2020
@yd-null
Copy link
Contributor Author

yd-null commented Apr 24, 2020

Of course it does, what a blunder...

@zvecr zvecr requested a review from a team April 25, 2020 00:16
zvecr
zvecr requested changes Apr 25, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rev 1 and 5 currently share the same vid,

qmk_firmware/keyboards/westfoxtrot/cypher/rev5/config.h

Line 24 in a3d5f36

#define PRODUCT_ID 0xAA97
needs to be updated to something unique, 0xAA98 is currently unused (your via json will also need to be updated).

@zvecr zvecr requested a review from a team April 25, 2020 22:57
@yd-null
Copy link
Contributor Author

yd-null commented Apr 25, 2020

Sorry, I thought it was more of a rev bump a la plank rev1-6. Fixed.

@yd-null yd-null requested a review from zvecr April 28, 2020 12:41
@drashna drashna changed the title Add via support for cypher rev5 PCB [Keyboard] Add via support for cypher rev5 PCB Apr 29, 2020
@drashna drashna merged commit 5f5c2a2 into qmk:master Apr 29, 2020
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
@yd-null @mrlinuxfish
[Keyboard] Add via support for cypher rev5 PCB (qmk#8898)
ceaa811
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@yd-null @lorenzoernesto
[Keyboard] Add via support for cypher rev5 PCB (qmk#8898)
63cd751
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@yd-null @sowbug
[Keyboard] Add via support for cypher rev5 PCB (qmk#8898)
a7781e1
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@yd-null @turky
[Keyboard] Add via support for cypher rev5 PCB (qmk#8898)
8e21201
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@yd-null @jakobaa
[Keyboard] Add via support for cypher rev5 PCB (qmk#8898)
8456574
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@yd-null @sjmacneil
[Keyboard] Add via support for cypher rev5 PCB (qmk#8898)
d993a7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yd-null @drashna @zvecr @noroadsleft