Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of the number of LEDs and DEVICE_VER #8896

Merged
merged 3 commits into from
Apr 25, 2020
Merged

Correction of the number of LEDs and DEVICE_VER #8896

merged 3 commits into from
Apr 25, 2020

Conversation

Salicylic-acid3
Copy link
Contributor

The number of LED is changed from 5 to 6 on one side.
DEVICE_VER was changed to a number with no duplicates.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

The number of LED is changed from 5 to 6 on one side.
DEVICE_VER was changed to a number with no duplicates.
@mtei mtei added the keyboard label Apr 24, 2020
@mtei mtei requested a review from a team April 24, 2020 09:44
keyboards/7skb/rev1/config.h Outdated Show resolved Hide resolved
keyboards/7skb/rev1/config.h Outdated Show resolved Hide resolved
@zvecr zvecr merged commit b2dbc3f into qmk:master Apr 25, 2020
@zvecr
Copy link
Member

zvecr commented Apr 25, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants