Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIA keymap for JJ4x4 and general cleanup #8888

Merged
merged 1 commit into from
Apr 24, 2020
Merged

VIA keymap for JJ4x4 and general cleanup #8888

merged 1 commit into from
Apr 24, 2020

Conversation

fauxpark
Copy link
Member

Description

Seeing as I also have one of these...

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 23, 2020 02:07
@fauxpark fauxpark mentioned this pull request Apr 23, 2020
Merged
6 tasks
drashna
drashna approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, because of how small the matrix is, you could probably enable more than 4 layers. :D

@drashna drashna requested a review from a team April 23, 2020 20:33
@zvecr zvecr merged commit 8650b9f into qmk:master Apr 24, 2020
@fauxpark fauxpark deleted the jj4x4-via branch April 24, 2020 18:55
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
@fauxpark @mrlinuxfish
VIA keymap for JJ4x4 and general cleanup (qmk#8888)
6380f23
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@fauxpark @lorenzoernesto
VIA keymap for JJ4x4 and general cleanup (qmk#8888)
a7608bc
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@fauxpark @sowbug
VIA keymap for JJ4x4 and general cleanup (qmk#8888)
dbe7a9a
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@fauxpark @turky
VIA keymap for JJ4x4 and general cleanup (qmk#8888)
20ccb4e
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@fauxpark @jakobaa
VIA keymap for JJ4x4 and general cleanup (qmk#8888)
6f09407
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@fauxpark @sjmacneil
VIA keymap for JJ4x4 and general cleanup (qmk#8888)
e657fb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft left review comments

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @drashna @zvecr @noroadsleft