Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keymap] add chriskopher keymap for usb-usb converter #8856

Merged
merged 1 commit into from
Apr 28, 2020
Merged

[Keymap] add chriskopher keymap for usb-usb converter #8856

merged 1 commit into from
Apr 28, 2020

Conversation

chriskopher
Copy link
Contributor

Description

Add personal keymap for usb-usb converter.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@chriskopher
Copy link
Contributor Author

chriskopher commented Apr 19, 2020 •
edited
Loading

Hmm not sure why the CI build is breaking, it compiles locally on my machine. Looking into it.

From the CI build log:

Compiling: tmk_core/common/magic.c                                                                 make[1]: *** [tmk_core/rules.mk:386: .build/obj_converter_usb_usb_hasu_chriskopher/common/avr/xprintf.o] Error 1

make[1]: *** Waiting for unfinished jobs....

 [ERRORS]

 | 

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h: Assembler messages:

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:27: Error: unknown opcode `enum'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:29: Error: unknown opcode `_cko'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:30: Error: unknown opcode `_qwerty'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:32: Error: unknown opcode `_superdupe'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:33: Error: unknown opcode `_dev'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:35: Error: unknown opcode `_adjust'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:36: Error: junk at end of line, first unrecognized character is `}'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:38: Error: unknown opcode `enum'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:40: Error: unknown opcode `espc_l'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:41: Error: unknown opcode `espc_r'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:43: Error: unknown opcode `scln_cln'

 | ./keyboards/converter/usb_usb/keymaps/chriskopher/config.h:44: Error: junk at end of line, first unrecognized character is `}'

 |

@chriskopher
Copy link
Contributor Author

I am able to recreate with a clean environment. Will push update.

@zvecr zvecr added the keymap label Apr 19, 2020
@zvecr zvecr requested a review from a team April 19, 2020 22:16
@drashna drashna requested a review from a team April 23, 2020 19:42
@chriskopher
Copy link
Contributor Author

chriskopher commented Apr 23, 2020 •
edited
Loading

@drashna Great suggestions, thanks! Much cleaner now.

@chriskopher
Copy link
Contributor Author

@fauxpark Updated, thanks!

drashna
drashna approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@drashna drashna merged commit e1217da into qmk:master Apr 28, 2020
@chriskopher
Copy link
Contributor Author

Thanks!

@chriskopher chriskopher deleted the keymap_chriskopher branch April 28, 2020 14:18
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
@chriskopher @mrlinuxfish
[Keymap] add chriskopher keymap for usb-usb converter (qmk#8856)
267890f
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@chriskopher @lorenzoernesto
[Keymap] add chriskopher keymap for usb-usb converter (qmk#8856)
cb659f4
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@chriskopher @sowbug
[Keymap] add chriskopher keymap for usb-usb converter (qmk#8856)
7cbda6c
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@chriskopher @turky
[Keymap] add chriskopher keymap for usb-usb converter (qmk#8856)
8beae2e
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@chriskopher @jakobaa
[Keymap] add chriskopher keymap for usb-usb converter (qmk#8856)
5a582ad
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@chriskopher @sjmacneil
[Keymap] add chriskopher keymap for usb-usb converter (qmk#8856)
6d0947e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chriskopher @drashna @fauxpark @zvecr