Load keymap-level rules.mk when compiling keymap.json #8841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Apr 18, 2020
There was a problem hiding this comment.
Not a fan of the duplicate logic from https://github.com/qmk/qmk_firmware/blob/master/build_keyboard.mk#L104-L133, but I can see why its needed right now.
zvecr
approved these changes
Apr 18, 2020
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
mrlinuxfish
pushed a commit
to mrlinuxfish/qmk_firmware
that referenced
this pull request
May 3, 2020
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 24, 2020
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 12, 2020
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Load keymap-level rules.mk when compiling keymap.json
Types of Changes
Issues Fixed or Closed by This PR
Checklist