Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA support on XiuDi (XD) keyboards #8829

Merged
merged 6 commits into from
Jun 30, 2020
Merged

Add VIA support on XiuDi (XD) keyboards #8829

merged 6 commits into from
Jun 30, 2020

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Apr 17, 2020

Description

Updates to all XiuDi PCBs to have the via keymap. (except xd004 as that uses a 16U2)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Update keyboards to have VIA support

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Apr 19, 2020
View reviewed changes
keyboards/xd60/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd87/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team April 19, 2020 17:12
fauxpark
fauxpark requested changes Apr 19, 2020
View reviewed changes
keyboards/xd004/v1/config.h Outdated Show resolved Hide resolved
keyboards/xd60/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd60/rev2/config.h Outdated Show resolved Hide resolved
keyboards/xd60/rev3/config.h Outdated Show resolved Hide resolved
keyboards/xd68/config.h Outdated Show resolved Hide resolved
keyboards/xd96/config.h Outdated Show resolved Hide resolved
keyboards/xd84/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd84/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
Erovia
Erovia requested changes Apr 19, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom keycodes are totally unnecessary/useless.
The user will overwrite them with VIA and unless they dig up the keymap, there is no way they can set use them again.

keyboards/xd75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd87/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd87/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd60/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd84/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd84/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@Xelus22 Xelus22 requested review from Erovia and fauxpark April 23, 2020 05:18
drashna
drashna requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a mix of tabs and spaces for indentation here.

keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/xd96/keymaps/via/keymap.c Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Apr 28, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@zvecr zvecr mentioned this pull request May 4, 2020
Closed
13 tasks
@matthewdias matthewdias mentioned this pull request May 4, 2020
Merged
6 tasks
@zvecr zvecr added the via Adds via keymap and/or updates keyboard for via support label May 15, 2020
@stale
Copy link

stale bot commented Jun 30, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Jun 30, 2020
@Erovia Erovia requested a review from fauxpark June 30, 2020 17:18
@Erovia Erovia closed this Jun 30, 2020
@Erovia Erovia reopened this Jun 30, 2020
@Erovia Erovia merged commit 6600f32 into qmk:master Jun 30, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@Xelus22 @fauxpark
@Erovia @jakobaa
Add VIA support on XiuDi (XD) keyboards (qmk#8829)
f35996f 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Erovia <[email protected]>
@matoushybl matoushybl mentioned this pull request Jul 7, 2020
Merged
6 tasks
@2Moons-JP 2Moons-JP mentioned this pull request Oct 9, 2020
Merged
6 tasks
@se-bastiaan se-bastiaan mentioned this pull request Oct 28, 2020
Merged
6 tasks
@Xelus22 Xelus22 deleted the xiudiUpdate branch June 2, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@Erovia Erovia Erovia approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Xelus22 @drashna @Erovia @fauxpark @zvecr