Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New 65 ANSI Blocker layouts: Split BS, Tsangan #8793

Merged
merged 9 commits into from
Apr 25, 2020
Merged

New 65 ANSI Blocker layouts: Split BS, Tsangan #8793

merged 9 commits into from
Apr 25, 2020

Conversation

brandonschlack
Copy link
Contributor

Adds 2 65 ANSI Blocker layout variations as default layouts: Split BS & Tsangan. Since many 65 ANSI Blocker keyboards also support support split backspace and 7u bottom row configurations, adding these default layouts will enable community layout support for these popular configurations going forward.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@brandonschlack
Add 65 ANSI Blocker Split BS default layout
4c00324 
- Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace
@brandonschlack
Add 65 ANSI Blocker Tsangan default layout
87d46b7 
- Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration.
@drashna drashna requested review from noroadsleft and a team April 19, 2020 01:01
@drashna drashna added the keymap label Apr 19, 2020
noroadsleft
noroadsleft requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes

  • layouts/default/65_ansi_blocker_split_bs/default_65_ansi_blocker/keymap.c needs to be renamed to layouts/default/65_ansi_blocker_split_bs/default_65_ansi_blocker_split_bs/keymap.c
  • layouts/default/65_ansi_blocker_tsangan/default_65_ansi_blocker/keymap.c needs to be renamed to
    layouts/default/65_ansi_blocker_tsangan/default_65_ansi_blocker_tsangan/keymap.c
  • The suggestions I made to the 65_ansi_blocker_tsangan layout remove the split Backspace, using a 2u Backspace instead. The reason for this is to make it consistent with the 60% Tsangan layouts, which only change the bottom row sizing. 60_ansi_tsangan and 60_iso_tsangan still use 2u Backspace; 60_tsangan_hhkb gets its split Backspace from being HHKB layout, rather than being Tsangan.

layouts/default/65_ansi_blocker_split_bs/readme.md Outdated Show resolved Hide resolved
layouts/default/65_ansi_blocker_tsangan/default_65_ansi_blocker/keymap.c Outdated Show resolved Hide resolved
layouts/default/65_ansi_blocker_tsangan/default_65_ansi_blocker/keymap.c Outdated Show resolved Hide resolved
layouts/default/65_ansi_blocker_tsangan/info.json Outdated Show resolved Hide resolved
layouts/default/65_ansi_blocker_tsangan/layout.json Outdated Show resolved Hide resolved
layouts/default/65_ansi_blocker_tsangan/readme.md Outdated Show resolved Hide resolved
@noroadsleft noroadsleft self-assigned this Apr 20, 2020
@zvecr zvecr requested a review from noroadsleft April 23, 2020 20:09
@brandonschlack
Copy link
Contributor Author

Implemented feedback. Ready for review.

@noroadsleft noroadsleft merged commit 3337eb1 into qmk:master Apr 25, 2020
@noroadsleft
Copy link
Member

Thanks!

@bcat bcat mentioned this pull request Apr 26, 2020
Merged
13 tasks
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
@brandonschlack @mrlinuxfish
New 65 ANSI Blocker layouts: Split BS, Tsangan (qmk#8793)
7c25093 
* Add 65 ANSI Blocker Split BS default layout

- Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace

* Add 65 ANSI Blocker Tsangan default layout

- Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration.

* Fix file names

* Fix 65_ansi_blocker_tsangan keymap

* Fix 65_ansi_blocker_split_bs alignment

* Fix readme name for 65_ansi_blocker_split_bs

* Change 65_ansi_blocker_tsangan to 2u backspace

* Change spaces in preview to NBSP

* Change more spaces in preview to NBSP (right-alt)
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@brandonschlack @lorenzoernesto
New 65 ANSI Blocker layouts: Split BS, Tsangan (qmk#8793)
11fb1fa 
* Add 65 ANSI Blocker Split BS default layout

- Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace

* Add 65 ANSI Blocker Tsangan default layout

- Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration.

* Fix file names

* Fix 65_ansi_blocker_tsangan keymap

* Fix 65_ansi_blocker_split_bs alignment

* Fix readme name for 65_ansi_blocker_split_bs

* Change 65_ansi_blocker_tsangan to 2u backspace

* Change spaces in preview to NBSP

* Change more spaces in preview to NBSP (right-alt)
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@brandonschlack @sowbug
New 65 ANSI Blocker layouts: Split BS, Tsangan (qmk#8793)
fc2db77 
* Add 65 ANSI Blocker Split BS default layout

- Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace

* Add 65 ANSI Blocker Tsangan default layout

- Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration.

* Fix file names

* Fix 65_ansi_blocker_tsangan keymap

* Fix 65_ansi_blocker_split_bs alignment

* Fix readme name for 65_ansi_blocker_split_bs

* Change 65_ansi_blocker_tsangan to 2u backspace

* Change spaces in preview to NBSP

* Change more spaces in preview to NBSP (right-alt)
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@brandonschlack @turky
New 65 ANSI Blocker layouts: Split BS, Tsangan (qmk#8793)
7ec2cc9 
* Add 65 ANSI Blocker Split BS default layout

- Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace

* Add 65 ANSI Blocker Tsangan default layout

- Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration.

* Fix file names

* Fix 65_ansi_blocker_tsangan keymap

* Fix 65_ansi_blocker_split_bs alignment

* Fix readme name for 65_ansi_blocker_split_bs

* Change 65_ansi_blocker_tsangan to 2u backspace

* Change spaces in preview to NBSP

* Change more spaces in preview to NBSP (right-alt)
@brandonschlack brandonschlack deleted the new_65_ansi_blocker_layouts branch June 23, 2020 17:49
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@brandonschlack @jakobaa
New 65 ANSI Blocker layouts: Split BS, Tsangan (qmk#8793)
0538f6c 
* Add 65 ANSI Blocker Split BS default layout

- Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace

* Add 65 ANSI Blocker Tsangan default layout

- Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration.

* Fix file names

* Fix 65_ansi_blocker_tsangan keymap

* Fix 65_ansi_blocker_split_bs alignment

* Fix readme name for 65_ansi_blocker_split_bs

* Change 65_ansi_blocker_tsangan to 2u backspace

* Change spaces in preview to NBSP

* Change more spaces in preview to NBSP (right-alt)
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@brandonschlack @sjmacneil
New 65 ANSI Blocker layouts: Split BS, Tsangan (qmk#8793)
dc05ebb 
* Add 65 ANSI Blocker Split BS default layout

- Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace

* Add 65 ANSI Blocker Tsangan default layout

- Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration.

* Fix file names

* Fix 65_ansi_blocker_tsangan keymap

* Fix 65_ansi_blocker_split_bs alignment

* Fix readme name for 65_ansi_blocker_split_bs

* Change 65_ansi_blocker_tsangan to 2u backspace

* Change spaces in preview to NBSP

* Change more spaces in preview to NBSP (right-alt)
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@brandonschlack
New 65 ANSI Blocker layouts: Split BS, Tsangan (qmk#8793)
39551d7 
* Add 65 ANSI Blocker Split BS default layout

- Add new 65 ANSI Blocker Split BS layout as many 65 ANSI Blocker layouts also support split backspace

* Add 65 ANSI Blocker Tsangan default layout

- Add new 65 ANSI Blocker Tsangan layout as many 65 ANSI Blocker layouts also support a split backspace and a 7u bottom row configuration.

* Fix file names

* Fix 65_ansi_blocker_tsangan keymap

* Fix 65_ansi_blocker_split_bs alignment

* Fix readme name for 65_ansi_blocker_split_bs

* Change 65_ansi_blocker_tsangan to 2u backspace

* Change spaces in preview to NBSP

* Change more spaces in preview to NBSP (right-alt)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees

@noroadsleft noroadsleft

Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brandonschlack @noroadsleft @drashna @fauxpark