-
-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latinpad(dural rotary encoder OLED macro pad) #8766
Conversation
As a note, you do not need to keep closing and reopening PRs for this keyboard. This looses context from any potential outstanding review suggestions. You can keep pushing to the same branch to add changes, and we can edit the title/comments to reflect things like board renames. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make all the copyright headers identical. You've been inconsistent with all of them.
thanks a lot Co-Authored-By: ridingqwerty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two more small things from me, one of which I missed the first time around.
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Thank you all of the GOD,Sir my tears in my eye,I am grateful for your serious attitude and patience in correcting mistakes。best wishes |
Co-Authored-By: ridingqwerty <[email protected]> Co-Authored-By: Ryan <[email protected]> Co-Authored-By: Joel Challis <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]> Co-Authored-By: James Young <[email protected]>
Co-Authored-By: ridingqwerty <[email protected]> Co-Authored-By: Ryan <[email protected]> Co-Authored-By: Joel Challis <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]> Co-Authored-By: James Young <[email protected]>
Co-Authored-By: ridingqwerty <[email protected]> Co-Authored-By: Ryan <[email protected]> Co-Authored-By: Joel Challis <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]> Co-Authored-By: James Young <[email protected]>
Co-Authored-By: ridingqwerty <[email protected]> Co-Authored-By: Ryan <[email protected]> Co-Authored-By: Joel Challis <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]> Co-Authored-By: James Young <[email protected]>
Co-Authored-By: ridingqwerty <[email protected]> Co-Authored-By: Ryan <[email protected]> Co-Authored-By: Joel Challis <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]> Co-Authored-By: James Young <[email protected]>
)" This reverts commit 23cfc4b.
Create latinpad.json into src/other ,QMKPR(Merged)qmk/qmk_firmware#8766
Co-Authored-By: ridingqwerty <[email protected]> Co-Authored-By: Ryan <[email protected]> Co-Authored-By: Joel Challis <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]> Co-Authored-By: James Young <[email protected]>
dural rotary encoder macro pad
Description
dural rotary encoder macro pad
Types of Changes
Checklist