Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latinpad(dural rotary encoder OLED macro pad) #8766

Merged
merged 54 commits into from
Apr 28, 2020
Merged

latinpad(dural rotary encoder OLED macro pad) #8766

merged 54 commits into from
Apr 28, 2020

Conversation

latincompass
Copy link
Contributor

@latincompass latincompass commented Apr 12, 2020

dural rotary encoder macro pad

Description

dural rotary encoder macro pad

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr
Copy link
Member

zvecr commented Apr 12, 2020

As a note, you do not need to keep closing and reopening PRs for this keyboard. This looses context from any potential outstanding review suggestions.

You can keep pushing to the same branch to add changes, and we can edit the title/comments to reflect things like board renames.

@zvecr zvecr added the keyboard label Apr 12, 2020
@zvecr zvecr requested a review from a team April 12, 2020 01:13
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make all the copyright headers identical. You've been inconsistent with all of them.

keyboards/latinpad/info.json Outdated Show resolved Hide resolved
keyboards/latinpad/info.json Outdated Show resolved Hide resolved
keyboards/latinpad/info.json Outdated Show resolved Hide resolved
keyboards/latinpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/latinpad/readme.md Outdated Show resolved Hide resolved
keyboards/latinpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/latinpad/config.h Show resolved Hide resolved
keyboards/latinpad/keymaps/default/keymap.c Show resolved Hide resolved
@tzarc tzarc requested a review from a team April 12, 2020 01:22
thanks a lot

Co-Authored-By: ridingqwerty <[email protected]>
keyboards/latinpad/rules.mk Show resolved Hide resolved
keyboards/latinpad/readme.md Outdated Show resolved Hide resolved
keyboards/latinpad/lib/glcdfont.c Outdated Show resolved Hide resolved
keyboards/latinpad/lib/glcdfont.c Outdated Show resolved Hide resolved
keyboards/latinpad/latinpad.c Outdated Show resolved Hide resolved
keyboards/latinpad/keymaps/default/config.h Outdated Show resolved Hide resolved
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more small things from me, one of which I missed the first time around.

keyboards/latinpad/config.h Outdated Show resolved Hide resolved
keyboards/latinpad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@drashna drashna merged commit 23cfc4b into qmk:master Apr 28, 2020
@latincompass
Copy link
Contributor Author

Thank you all of the GOD,Sir my tears in my eye,I am grateful for your serious attitude and patience in correcting mistakes。best wishes

mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
Co-Authored-By: ridingqwerty <[email protected]>
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: James Young <[email protected]>
@latincompass latincompass changed the title latinpad(Original:hasupad,RENAMED latinpad) latinpad(dural rotary encoder OLED macro pad) May 3, 2020
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
Co-Authored-By: ridingqwerty <[email protected]>
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: James Young <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
Co-Authored-By: ridingqwerty <[email protected]>
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: James Young <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
Co-Authored-By: ridingqwerty <[email protected]>
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: James Young <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
Co-Authored-By: ridingqwerty <[email protected]>
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: James Young <[email protected]>
latincompass added a commit to latincompass/qmk_firmware that referenced this pull request Aug 13, 2020
wilba added a commit to the-via/keyboards that referenced this pull request Sep 15, 2020
Create latinpad.json into src/other ,QMKPR(Merged)qmk/qmk_firmware#8766
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
Co-Authored-By: ridingqwerty <[email protected]>
Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>
Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: James Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants