Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add pimentoso/paddino02 #8756

Merged
merged 10 commits into from
Apr 25, 2020
Merged

[Keyboard] Add pimentoso/paddino02 #8756

merged 10 commits into from
Apr 25, 2020

Conversation

Pimentoso
Copy link
Contributor

@Pimentoso Pimentoso commented Apr 10, 2020 •
edited
Loading

Added QMK support for my macropad, instead of relying to kbfirmware.com json files.

Project page: https://github.com/Pimentoso/Paddino02

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

LostQuasar
LostQuasar suggested changes Apr 10, 2020
View reviewed changes
keyboards/pimentoso/paddino02/rev1/config.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev1/rev1.c Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/left/config.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/left/left.c Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/right.c Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/config.h Outdated Show resolved Hide resolved
ridingqwerty
ridingqwerty requested changes Apr 10, 2020
View reviewed changes
keyboards/pimentoso/paddino02/rev1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/left/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/left/left.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/right.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/right.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rules.mk Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rules.mk Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Apr 10, 2020
View reviewed changes
keyboards/pimentoso/paddino02/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/right.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/right.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/right.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Apr 10, 2020
@Pimentoso
Copy link
Contributor Author

Applied the requested changes. Thanks guys.

zvecr
zvecr requested changes Apr 10, 2020
View reviewed changes
keyboards/pimentoso/paddino02/rev1/config.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/readme.md Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/config.h Outdated Show resolved Hide resolved
@Pimentoso Pimentoso requested a review from zvecr April 11, 2020 14:45
@drashna drashna requested a review from a team April 12, 2020 21:10
zvecr
zvecr requested changes Apr 12, 2020
View reviewed changes
keyboards/pimentoso/paddino02/config.h Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from ridingqwerty April 12, 2020 22:39
fauxpark
fauxpark requested changes Apr 13, 2020
View reviewed changes
keyboards/pimentoso/paddino02/rev1/config.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/left/config.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rev2/right/config.h Outdated Show resolved Hide resolved
keyboards/pimentoso/paddino02/rules.mk Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Apr 19, 2020

Wait, why the left and right revisions?

@Pimentoso
Copy link
Contributor Author

@drashna same pcb, you flip it over but the pro micro is always soldered on the udnerside, so the pins of the matrix change

noroadsleft
noroadsleft approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 52af38d into qmk:master Apr 25, 2020
@noroadsleft
Copy link
Member

Thanks!

@Pimentoso Pimentoso deleted the paddino02 branch April 26, 2020 20:15
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
@Pimentoso @mrlinuxfish
[Keyboard] Add pimentoso/paddino02 (qmk#8756)
31df947 
* added pimentoso/paddino02

* pimentoso/paddino02 fix config

* pimentoso/paddino02 fix right handed keymap

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@Pimentoso @lorenzoernesto
[Keyboard] Add pimentoso/paddino02 (qmk#8756)
ad40519 
* added pimentoso/paddino02

* pimentoso/paddino02 fix config

* pimentoso/paddino02 fix right handed keymap

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@Pimentoso @sowbug
[Keyboard] Add pimentoso/paddino02 (qmk#8756)
a0ddf31 
* added pimentoso/paddino02

* pimentoso/paddino02 fix config

* pimentoso/paddino02 fix right handed keymap

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@Pimentoso @turky
[Keyboard] Add pimentoso/paddino02 (qmk#8756)
9dcdb09 
* added pimentoso/paddino02

* pimentoso/paddino02 fix config

* pimentoso/paddino02 fix right handed keymap

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@Pimentoso @jakobaa
[Keyboard] Add pimentoso/paddino02 (qmk#8756)
65a39bc 
* added pimentoso/paddino02

* pimentoso/paddino02 fix config

* pimentoso/paddino02 fix right handed keymap

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@Pimentoso @sjmacneil
[Keyboard] Add pimentoso/paddino02 (qmk#8756)
5bba879 
* added pimentoso/paddino02

* pimentoso/paddino02 fix config

* pimentoso/paddino02 fix right handed keymap

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style

* pimentoso/paddino02 fix readme

* pimentoso/paddino02 code style

* pimentoso/paddino02 code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LostQuasar LostQuasar LostQuasar requested changes

@fauxpark fauxpark fauxpark approved these changes

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna Awaiting requested review from drashna

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Pimentoso @drashna @noroadsleft @fauxpark @LostQuasar @ridingqwerty @zvecr