split75 ps2avrGB support #8511

artjomsR · 2020-03-21T14:26:12Z

Added support for split75 keyboard (https://a.aliexpress.com/_BT9raf). Provided a default and a personal map. Work adapted from https://github.com/walkerstop/qmk_firmware/tree/split75/keyboards/wheatfield/split75 All credit goes to him. I've tidied up the keymap (removed 3 extra keys), a couple of functions and this Readme.

Overall the keyboard works for me and happy with it so I'd like this to be merged in so more people can find it.

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

default keymap

zvecr

Also keyboards/split75/bootloadHID needs to be deleted.

keyboards/split75/README.md

keyboards/ergodone/config.h

keyboards/split75/config.h

keyboards/split75/keymaps/art/keymap.c

keyboards/split75/program

keyboards/split75/split75.c

zvecr

info.json is also required https://docs.qmk.fm/#/reference_configurator_support

keyboards/split75/keymaps/default/keymap.c

keyboards/split75/usbconfig.h

keyboards/split75/split75.h

keyboards/split75/keymaps/art/keymap.c

keyboards/split75/keymaps/default/keymap.c

keyboards/split75/rules.mk

Co-Authored-By: Joel Challis <[email protected]>

…into art-split75

Co-Authored-By: Joel Challis <[email protected]>

artjomsR · 2020-04-03T17:03:31Z

@fauxpark I've committed your changes and now CapsLock behaves like Ctrl and RAlt behaves like right GUI (on default firmware too)

artjomsR · 2020-04-03T18:36:18Z

@fauxpark Appreciate the approval but just 1 question as per above: I've committed your changes and now CapsLock behaves like Ctrl and RAlt behaves like right GUI (on default firmware too)

fauxpark · 2020-04-03T18:41:45Z

keyboards/split75/rules.mk

+# Build Options
+# change yes to no to disable
+#
+BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration


Suggested change

BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration

BOOTMAGIC_ENABLE = lite # Virtual DIP switch configuration

Sounds like you activated Bootmagic somehow... but it clearly was not enabled. Try this, and holding the key at (0,0) in the matrix while plugging it in. The board should go into bootloader mode, but also it will clear the EEPROM. If that still doesn't fix it perhaps the layout macro is incorrect.

Hmm that's strange, I'm always flashing like this (holding 0th key and plugging it in). Never seen it before up until the recent changes. What do you mean by layout macro specifically?

I've checked out to 7b1313f but I'm still getting the same issue :( I've noticed this issue sometimes where after flashing, LCtrl (which I press down for flashing) stays pressed (or so the PC thinks). But it rarely happens, not sure what exactly causes this.

It also happened this time and afterwards the Caps Lock stopped working for the first time

I mean the LAYOUT macro defined in split75.h.

Hi, just a couple of things, even if you can't answer all of them it'll be appreciated:

I've tried reflashing multiple times but that didn't help. Ultimately I've managed to clear the EPROM. I've done this via the ps2avrGB BootMapper client. Obviously it's difficult to say how I'm periodically ending up in this situation but your theory about activating Bootmagic is plausible. Would adding eg

#define BOOTMAGIC_LITE_ROW 1 #define BOOTMAGIC_LITE_COLUMN 1

help to move it from the LCtrl which I use to flash the keyboard?

Is there any way from the QMK env to clear the EPROM?

How is it possible to know that LAYOUT is incorrect in split.h? I've been using this keyboard with QMK for a few weeks and aside from flashing (which would sometimes make LCtrl sticky or in this case, for the first time, break Caps Lock) I've had no issues with it. How would I know the correct layout - I've mentioned that I've taken over this PR from another guy - is it basically reverse engineering / requires access to schematics?

My thought with the layout being wrong was that you'd somehow been using it with some of the Bootmagic swaps active until now, and something triggered QMK to clear the EEPROM, setting it all back to normal. But seeing as you probably have not touched the layout macro, I doubt that is the case.

You can assign the EEP_RST keycode to clear the EEPROM from within QMK. Some bootloaders have the ability to change the contents of the EEPROM, but not bootloadHID unfortunately.

If clearing the EEPROM has fixed the swapped keys, then that should be fine (I have no idea how that would have been activated to begin with, though 🤷‍♂). If not, that means the mapping of those keys in the layout macro should be swapped - but again, I think it's likely correct given the existing work put into the code.

Ok that's fair, thank you for clarifying. So I guess swapping the bootmagic key wouldn't help in this case?

noroadsleft

This should be renamed so it's in keyboards/wheatfield/split75/ instead, and the readme updated to match.

Everything else looks good to me though.

artjomsR · 2020-04-05T08:37:51Z

I've squashed the commits and pushed them to a new branch. Will it be possible to merge that instead? https://github.com/qmk/qmk_firmware/compare/master...artjomsR:art-split75-s?expand=1

Or shall I just force push to this branch?

noroadsleft

I've squashed the commits and pushed them to a new branch. Will it be possible to merge that instead? https://github.com/qmk/qmk_firmware/compare/master...artjomsR:art-split75-s?expand=1

Or shall I just force push to this branch?

Can't change the source branch on a pull request. We squash on merge the overwhelming majority of the time, so that doesn't matter anyway.

Thanks!

@skullydazed

* 'master' of https://github.com/qmk/qmk_firmware: (53 commits) Set the correct RGB LED count on YD60MQ (qmk#8629) [Keymap] Updates to personal keymaps (qmk#8665) Fix compile issues related to NO_ACTION_MACRO/FUNCTION and LTO_ENABLE (qmk#8663) [Keymap] Userspace update Rgb layers code (qmk#8659) Add Choconum (qmk#8709) Add Via keymap for BM16-A (qmk#8681) Fix edge-case with config Don't hide for devs... Apply @skullydazed's suggestions, move 'import milc' Make dedicated sections for user/dev commands in docs Rebase on master, hide some other subcommands Use milc for config check, requirements fixes CLI: Add development mode support Update info.json (qmk#8723) format code according to conventions [skip ci] spi_master for AVR (qmk#8299) DennyTom's buttery_engine (qmk#8138) add via support for kira80 (qmk#8677) [Keyboard] Wheatfield Split75 (qmk#8511) Correctly handle json keymaps with ANY() ...

* Added split75 keyboard * tidy up commented out code + removed default * added visual map * proper led functions. more layers for keymap * led functions. moved mod keys to numbers * double tapping toggle + leds on power on * media keys fix * clean up of commented out code and unnecessary functions. readme update. default keymap * removed bootloadHID file * Update keyboards/split75/config.h * Update keyboards/split75/config.h * Update keyboards/split75/config.h * Update keyboards/split75/config.h * removed python flashing script * Update keyboards/split75/keymaps/default/keymap.c * Update keyboards/split75/split75.h * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/keymaps/default/keymap.c * reintroduced empty matrix_scan_user to default keymap * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/usbconfig.h * Update keyboards/ergodone/config.h * Update keyboards/split75/keymaps/art/keymap.c * updated readme file * Update keyboards/split75/usbconfig.h * Update keyboards/split75/rules.mk * Update keyboards/split75/split75.c * code fix after suggestions * defined tapping toggle as double tap * added info.json * Update keyboards/split75/config.h * fix for leds not displaying properly when initialising * Update keyboards/split75/README.md * Update keyboards/split75/keymaps/default/keymap.c * Update keyboards/split75/keymaps/art/keymap.c * changed product description fields * renamed user functions * indentation fix * Update keyboards/split75/usbconfig.h * Update keyboards/split75/usbconfig.h * Update keyboards/split75/usbconfig.h * Update keyboards/split75/usbconfig.h * Update keyboards/split75/usbconfig.h * Update keyboards/split75/split75.c * Update keyboards/split75/split75.c * art keymap update * Update keyboards/split75/config.h * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/split75.c * Update keyboards/split75/keymaps/art/keymap.c * Update keyboards/split75/keymaps/default/keymap.c * Update keyboards/split75/split75.c * Update keyboards/split75/matrix.c * Update keyboards/split75/rules.mk * Update keyboards/split75/split75.c * Update keyboards/split75/split75.c * Update keyboards/split75/split75.c * Update keyboards/split75/config.h * Update keyboards/split75/split75.c * disable underglow on sleep and enabled backlighting * Update keyboards/split75/usbconfig.h * Update keyboards/split75/usbconfig.h * Update keyboards/split75/usbconfig.h * Update keyboards/split75/usbconfig.h * Update keyboards/split75/usbconfig.h * Update keyboards/split75/usbconfig.h * personal keymap update * changed boot animation * consistent whitespace * Tidied up default notes and unnecessary comments * Unique Vendor ID * remove usb config file * corrected manufacturer * Update keyboards/split75/config.h * Update keyboards/split75/README.md * Update keyboards/split75/split75.c * Update keyboards/split75/split75.c * Update keyboards/split75/split75.c * Update keyboards/split75/split75.c * Update keyboards/split75/split75.c * Update keyboards/split75/split75.c * Update keyboards/split75/split75.h * Update keyboards/split75/split75.h * Update keyboards/split75/split75.h * Update keyboards/split75/split75.c * Update keyboards/split75/matrix.c * Update keyboards/split75/matrix.c * Update keyboards/split75/matrix.c * Update keyboards/split75/matrix.c * Update keyboards/split75/split75.h * Personal keymap restore after refactor * Moved to wheatfield folder + updated readme

mustache-inc added 13 commits February 27, 2020 22:15

Added split75 keyboard

d3ddcf6

tidy up commented out code + removed default

af6c597

Merge branch 'master' into split74

ae7e377

added visual map

d9e62a5

Merge branch 'master' into art-split74

f4fae2d

Merge branch 'master' into art-split75

67042c1

Merge branch 'master' into art-split75

4fafd5e

proper led functions. more layers for keymap

d0ed572

led functions. moved mod keys to numbers

082818c

double tapping toggle + leds on power on

beaa7ab

media keys fix

6b0e7ff

clean up of commented out code and unnecessary functions. readme update.

65e7e8c

default keymap

Merge branch 'master' into art-split75

788ac07

zvecr requested changes Mar 21, 2020

View reviewed changes

zvecr added the keyboard label Mar 21, 2020

zvecr requested changes Mar 21, 2020

View reviewed changes

zvecr reviewed Mar 21, 2020

View reviewed changes

keyboards/split75/rules.mk Outdated Show resolved Hide resolved

mustache-inc and others added 13 commits March 21, 2020 16:12

removed bootloadHID file

db805c9

Update keyboards/split75/config.h

38dbb90

Co-Authored-By: Joel Challis <[email protected]>

Update keyboards/split75/config.h

002a0da

Co-Authored-By: Joel Challis <[email protected]>

Update keyboards/split75/config.h

5c0f59d

Co-Authored-By: Joel Challis <[email protected]>

Update keyboards/split75/config.h

0ebcdbc

Co-Authored-By: Joel Challis <[email protected]>

removed python flashing script

0fd99de

Merge branch 'art-split75' of https://github.com/artjomsR/qmk_firmware …

8f6f3c0

…into art-split75

Update keyboards/split75/keymaps/default/keymap.c

be6b809

Co-Authored-By: Joel Challis <[email protected]>

Update keyboards/split75/split75.h

877915a

Co-Authored-By: Joel Challis <[email protected]>

Update keyboards/split75/keymaps/art/keymap.c

cb56c36

Co-Authored-By: Joel Challis <[email protected]>

Update keyboards/split75/keymaps/art/keymap.c

5042e24

Co-Authored-By: Joel Challis <[email protected]>

Update keyboards/split75/keymaps/art/keymap.c

394853a

Co-Authored-By: Joel Challis <[email protected]>

Update keyboards/split75/keymaps/default/keymap.c

76efb90

Co-Authored-By: Joel Challis <[email protected]>

artjomsR added 2 commits April 3, 2020 18:25

Personal keymap restore after refactor

f649664

Merge branch 'master' into art-split75

10a4439

artjomsR requested a review from fauxpark April 3, 2020 17:28

fauxpark approved these changes Apr 3, 2020

View reviewed changes

fauxpark requested a review from a team April 3, 2020 18:34

fauxpark reviewed Apr 3, 2020

View reviewed changes

noroadsleft requested changes Apr 5, 2020

View reviewed changes

drashna approved these changes Apr 5, 2020

View reviewed changes

artjomsR added 2 commits April 5, 2020 09:19

Moved to wheatfield folder + updated readme

5f0e282

Merge branch 'master' into art-split75

c319848

artjomsR requested a review from noroadsleft April 5, 2020 08:37

noroadsleft approved these changes Apr 7, 2020

View reviewed changes

noroadsleft merged commit 3349a8b into qmk:master Apr 7, 2020

valpackett mentioned this pull request Jul 31, 2020

[Keyboard] Add Spider Island 78 key ps2avrGB based keyboard #9900

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

split75 ps2avrGB support #8511

split75 ps2avrGB support #8511

artjomsR commented Mar 21, 2020 •

edited

Loading

zvecr left a comment

zvecr left a comment

artjomsR commented Apr 3, 2020 •

edited

Loading

artjomsR commented Apr 3, 2020

fauxpark Apr 3, 2020

artjomsR Apr 3, 2020

artjomsR Apr 3, 2020

fauxpark Apr 3, 2020

artjomsR Apr 3, 2020

fauxpark Apr 3, 2020

artjomsR Apr 3, 2020

noroadsleft left a comment

artjomsR commented Apr 5, 2020

noroadsleft left a comment

	BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration
	BOOTMAGIC_ENABLE = lite # Virtual DIP switch configuration

split75 ps2avrGB support #8511

split75 ps2avrGB support #8511

Conversation

artjomsR commented Mar 21, 2020 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

zvecr left a comment

Choose a reason for hiding this comment

zvecr left a comment

Choose a reason for hiding this comment

artjomsR commented Apr 3, 2020 • edited Loading

artjomsR commented Apr 3, 2020

fauxpark Apr 3, 2020

Choose a reason for hiding this comment

artjomsR Apr 3, 2020

Choose a reason for hiding this comment

artjomsR Apr 3, 2020

Choose a reason for hiding this comment

fauxpark Apr 3, 2020

Choose a reason for hiding this comment

artjomsR Apr 3, 2020

Choose a reason for hiding this comment

fauxpark Apr 3, 2020

Choose a reason for hiding this comment

artjomsR Apr 3, 2020

Choose a reason for hiding this comment

noroadsleft left a comment

Choose a reason for hiding this comment

artjomsR commented Apr 5, 2020

noroadsleft left a comment

Choose a reason for hiding this comment

artjomsR commented Mar 21, 2020 •

edited

Loading

artjomsR commented Apr 3, 2020 •

edited

Loading