Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename qmk json-keymap to qmk json2c #8372

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Rename qmk json-keymap to qmk json2c #8372

merged 3 commits into from
Mar 10, 2020

Conversation

skullydazed
Copy link
Member

Per title, rename for consistency with other and future commands. Should also make this functionality easier to find for people who want to use configurator to generate keymap.c files.

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team March 10, 2020 14:28
@skullydazed skullydazed added cli qmk cli command python labels Mar 10, 2020
Copy link
Contributor

@Duckle29 Duckle29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skullydazed skullydazed merged commit 2a05d43 into master Mar 10, 2020
@skullydazed skullydazed deleted the rename_to_json2c branch March 10, 2020 20:51
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 11, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (107 commits)
  Add VIA support to Tokyo60. (qmk#8362)
  fix kira80 matrix mapping and add more preset layouts (qmk#8361)
  Rename qmk json-keymap to qmk json2c (qmk#8372)
  format code according to conventions [skip ci]
  Feature: RGBLight layers (qmk#7768)
  Refactor Equinox PCB revisions (qmk#8266)
  Replace tab indentation with spaces in is0 default keymap. (qmk#8368)
  Fix layer debug calls (qmk#8370)
  [Keymap] Added HHKB Keymap and user config (qmk#8119)
  Refactor rgblight_reconfig.h (qmk#7773)
  [Keyboard] Palette1202 (qmk#7736)
  [Keyboard] Helix add split common option (qmk#7718)
  Enable bootmagic lite for CU80 (qmk#8363)
  [Keymap] Update personal keymap (qmk#8354)
  Remove NO_UART defines from config.h for V-USB boards (qmk#8351)
  [Keyboard] Add Kira 80 support (qmk#8342)
  [Keyboard] Add PRKL30 keyboard (qmk#8319)
  Update Dvorak, Colemak and Workman keycode aliases (qmk#8217)
  Move splittest I2C (qmk#8346)
  [Keymap] planck layout for kifinnsson (qmk#8324)
  ...
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants