Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gcc version detection to qmk doctor #8338

Merged
merged 3 commits into from
Mar 8, 2020
Merged

Add gcc version detection to qmk doctor #8338

merged 3 commits into from
Mar 8, 2020

Conversation

skullydazed
Copy link
Member

Per title, basic version detection so we can warn users with gcc 9. Also outputs the version number of both to aid troubleshooting.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team March 7, 2020 23:06
@skullydazed skullydazed added cli qmk cli command python labels Mar 7, 2020
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team March 8, 2020 08:34
Copy link
Contributor

@Duckle29 Duckle29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe have a docs page describing what's involved with getting 8.3 on different OSes if we know?

@skullydazed
Copy link
Member Author

Maybe have a docs page describing what's involved with getting 8.3 on different OSes if we know?

That's a great idea, but I'm not knowledgable on what's required here. I'll open an issue to let someone take a stab at it, or so that people can coordinate effort around it.

@skullydazed skullydazed merged commit cf40c33 into master Mar 8, 2020
@skullydazed skullydazed deleted the doctor_avr_gcc branch March 8, 2020 16:21
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants