Fix conflicting types for 'tfp_printf' #8269

zvecr · 2020-02-29T10:47:35Z

Description

Pulling out the discussion within #8157 (comment) for a longer term fix for #8157.

https://github.com/mpaland/printf ticks the following boxes:

drop in replacement to existing solution
non void functions
binary printing support

seems to work fine with brief testing but it does increase ChibiOS based firmware by 750 bytes.

Types of Changes

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna · 2020-03-01T00:14:03Z

The only concern I have is if the MIT license is compatible.

Boettner-eric · 2020-03-01T00:36:14Z

I am having this issue right now on my proton c hardwired build and this branch does fix it

drashna · 2020-03-01T00:59:25Z

@Boettner-eric would you be opposed to approving the PR? Even if you're not a collaborator, you can do so. It just won't show it in green.

tzarc · 2020-03-01T01:55:50Z

I personally wouldn't have an issue removing the "breaking_change" label and getting this in to master.
Are there any real reasons to do so, other than the worry of the +750 bytes of flash? Are we close to the limit with any of the ARM builds, even customised keymaps?

Boettner-eric

Worked on proton c build with, encoders, oled and custom terminal

zvecr · 2020-03-01T02:19:18Z

As it missed acceptance window for the last breaking change, and adds a new submodule, i figured it would need to go via the next window. We could copy the code, then update to submodule next window, as a bit of a bodge to get this in sooner without hitting end user repo issues.

As for the size increase, the merge of nano specs means we would be no worse with this in than we were a few days ago. Personally I think the +750 bytes would be fine, but dont have the metrics to see how it really impacts the end user.

tzarc · 2020-03-01T02:41:24Z

Given that it's a new repo as opposed to a replacement of an existing directory with an equivalent submodule (lufa), I'd be more inclined to say "breaking changes not required". I don't really mind though, just figure that having this sitting on a branch and waiting for a few months, there's the possibility of divergence for people who try to apply the fix in their own branch to fix their boards.

noroadsleft

__attribute__ ((weak)) ✔️

noroadsleft · 2020-05-04T06:20:00Z

Thanks!

fauxpark · 2020-05-04T09:51:36Z

This should have been merged into future; Configurator is now broken for ARM boards with Console enabled (eg. 1upkeyboards/sweet16/v2/proton_c).

This reverts commit e17b55e.

* Refactor to use mpaland/printf * trim firmware size * remove keymap changes * run clang format * Fixup after rebase * fix up git-submodule command for printf

* Branch point for 2020 May 30 Breaking Change * Migrate `ACTION_LAYER_TOGGLE` to `TG()` (#8954) * Migrate `ACTION_MODS_ONESHOT` to `OSM()` (#8957) * Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()` (#8958) * Migrate `ACTION_LAYER_MODS` to `LM()` (#8959) * Migrate `ACTION_MODS_TAP_KEY` to `MT()` (#8968) * Convert V-USB usbdrv to a submodule (#8321) * Unify Tap Hold functions and documentation (#8348) * Changing board names to prevent confusion (#8412) * Move the Keyboardio Model01 to a keyboardio/ subdir (#8499) * Move spaceman keyboards (#8830) * Migrate miscellaneous `fn_actions` entries (#8977) * Migrate `ACTION_MODS_KEY` to chained mod keycodes (#8979) * Organizing my keyboards (plaid, tartan, ergoinu) (#8537) * Refactor Lily58 to use split_common (#6260) * Refactor zinc to use split_common (#7114) * Add a message if bin/qmk doesn't work (#9000) * Fix conflicting types for 'tfp_printf' (#8269) * Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup (#6480) * Refactor and updates to TKC1800 code (#8472) * Switch to qmk forks for everything (#9019) * audio refactor: replace deprecated PLAY_NOTE_ARRAY (#8484) * Audio enable corrections (2/3) (#8903) * Split HHKB to ANSI and JP layouts and Add VIA support for each (#8582) * Audio enable corrections (Part 4) (#8974) * Fix typo from PR7114 (#9171) * Augment future branch Changelogs (#8978) * Revert "Branch point for 2020 May 30 Breaking Change"

This reverts commit e17b55e.

* Branch point for 2020 May 30 Breaking Change * Migrate `ACTION_LAYER_TOGGLE` to `TG()` (qmk#8954) * Migrate `ACTION_MODS_ONESHOT` to `OSM()` (qmk#8957) * Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()` (qmk#8958) * Migrate `ACTION_LAYER_MODS` to `LM()` (qmk#8959) * Migrate `ACTION_MODS_TAP_KEY` to `MT()` (qmk#8968) * Convert V-USB usbdrv to a submodule (qmk#8321) * Unify Tap Hold functions and documentation (qmk#8348) * Changing board names to prevent confusion (qmk#8412) * Move the Keyboardio Model01 to a keyboardio/ subdir (qmk#8499) * Move spaceman keyboards (qmk#8830) * Migrate miscellaneous `fn_actions` entries (qmk#8977) * Migrate `ACTION_MODS_KEY` to chained mod keycodes (qmk#8979) * Organizing my keyboards (plaid, tartan, ergoinu) (qmk#8537) * Refactor Lily58 to use split_common (qmk#6260) * Refactor zinc to use split_common (qmk#7114) * Add a message if bin/qmk doesn't work (qmk#9000) * Fix conflicting types for 'tfp_printf' (qmk#8269) * Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup (qmk#6480) * Refactor and updates to TKC1800 code (qmk#8472) * Switch to qmk forks for everything (qmk#9019) * audio refactor: replace deprecated PLAY_NOTE_ARRAY (qmk#8484) * Audio enable corrections (2/3) (qmk#8903) * Split HHKB to ANSI and JP layouts and Add VIA support for each (qmk#8582) * Audio enable corrections (Part 4) (qmk#8974) * Fix typo from PR7114 (qmk#9171) * Augment future branch Changelogs (qmk#8978) * Revert "Branch point for 2020 May 30 Breaking Change"

* Refactor to use mpaland/printf * trim firmware size * remove keymap changes * run clang format * Fixup after rebase * fix up git-submodule command for printf

This reverts commit e17b55e.

* Branch point for 2020 May 30 Breaking Change * Migrate `ACTION_LAYER_TOGGLE` to `TG()` (qmk#8954) * Migrate `ACTION_MODS_ONESHOT` to `OSM()` (qmk#8957) * Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()` (qmk#8958) * Migrate `ACTION_LAYER_MODS` to `LM()` (qmk#8959) * Migrate `ACTION_MODS_TAP_KEY` to `MT()` (qmk#8968) * Convert V-USB usbdrv to a submodule (qmk#8321) * Unify Tap Hold functions and documentation (qmk#8348) * Changing board names to prevent confusion (qmk#8412) * Move the Keyboardio Model01 to a keyboardio/ subdir (qmk#8499) * Move spaceman keyboards (qmk#8830) * Migrate miscellaneous `fn_actions` entries (qmk#8977) * Migrate `ACTION_MODS_KEY` to chained mod keycodes (qmk#8979) * Organizing my keyboards (plaid, tartan, ergoinu) (qmk#8537) * Refactor Lily58 to use split_common (qmk#6260) * Refactor zinc to use split_common (qmk#7114) * Add a message if bin/qmk doesn't work (qmk#9000) * Fix conflicting types for 'tfp_printf' (qmk#8269) * Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup (qmk#6480) * Refactor and updates to TKC1800 code (qmk#8472) * Switch to qmk forks for everything (qmk#9019) * audio refactor: replace deprecated PLAY_NOTE_ARRAY (qmk#8484) * Audio enable corrections (2/3) (qmk#8903) * Split HHKB to ANSI and JP layouts and Add VIA support for each (qmk#8582) * Audio enable corrections (Part 4) (qmk#8974) * Fix typo from PR7114 (qmk#9171) * Augment future branch Changelogs (qmk#8978) * Revert "Branch point for 2020 May 30 Breaking Change"

* Refactor to use mpaland/printf * trim firmware size * remove keymap changes * run clang format * Fixup after rebase * fix up git-submodule command for printf

This reverts commit e17b55e.

* Branch point for 2020 May 30 Breaking Change * Migrate `ACTION_LAYER_TOGGLE` to `TG()` (qmk#8954) * Migrate `ACTION_MODS_ONESHOT` to `OSM()` (qmk#8957) * Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()` (qmk#8958) * Migrate `ACTION_LAYER_MODS` to `LM()` (qmk#8959) * Migrate `ACTION_MODS_TAP_KEY` to `MT()` (qmk#8968) * Convert V-USB usbdrv to a submodule (qmk#8321) * Unify Tap Hold functions and documentation (qmk#8348) * Changing board names to prevent confusion (qmk#8412) * Move the Keyboardio Model01 to a keyboardio/ subdir (qmk#8499) * Move spaceman keyboards (qmk#8830) * Migrate miscellaneous `fn_actions` entries (qmk#8977) * Migrate `ACTION_MODS_KEY` to chained mod keycodes (qmk#8979) * Organizing my keyboards (plaid, tartan, ergoinu) (qmk#8537) * Refactor Lily58 to use split_common (qmk#6260) * Refactor zinc to use split_common (qmk#7114) * Add a message if bin/qmk doesn't work (qmk#9000) * Fix conflicting types for 'tfp_printf' (qmk#8269) * Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup (qmk#6480) * Refactor and updates to TKC1800 code (qmk#8472) * Switch to qmk forks for everything (qmk#9019) * audio refactor: replace deprecated PLAY_NOTE_ARRAY (qmk#8484) * Audio enable corrections (2/3) (qmk#8903) * Split HHKB to ANSI and JP layouts and Add VIA support for each (qmk#8582) * Audio enable corrections (Part 4) (qmk#8974) * Fix typo from PR7114 (qmk#9171) * Augment future branch Changelogs (qmk#8978) * Revert "Branch point for 2020 May 30 Breaking Change"

* Refactor to use mpaland/printf * trim firmware size * remove keymap changes * run clang format * Fixup after rebase * fix up git-submodule command for printf

This reverts commit 9abf176.

* Branch point for 2020 May 30 Breaking Change * Migrate `ACTION_LAYER_TOGGLE` to `TG()` (qmk#8954) * Migrate `ACTION_MODS_ONESHOT` to `OSM()` (qmk#8957) * Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()` (qmk#8958) * Migrate `ACTION_LAYER_MODS` to `LM()` (qmk#8959) * Migrate `ACTION_MODS_TAP_KEY` to `MT()` (qmk#8968) * Convert V-USB usbdrv to a submodule (qmk#8321) * Unify Tap Hold functions and documentation (qmk#8348) * Changing board names to prevent confusion (qmk#8412) * Move the Keyboardio Model01 to a keyboardio/ subdir (qmk#8499) * Move spaceman keyboards (qmk#8830) * Migrate miscellaneous `fn_actions` entries (qmk#8977) * Migrate `ACTION_MODS_KEY` to chained mod keycodes (qmk#8979) * Organizing my keyboards (plaid, tartan, ergoinu) (qmk#8537) * Refactor Lily58 to use split_common (qmk#6260) * Refactor zinc to use split_common (qmk#7114) * Add a message if bin/qmk doesn't work (qmk#9000) * Fix conflicting types for 'tfp_printf' (qmk#8269) * Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup (qmk#6480) * Refactor and updates to TKC1800 code (qmk#8472) * Switch to qmk forks for everything (qmk#9019) * audio refactor: replace deprecated PLAY_NOTE_ARRAY (qmk#8484) * Audio enable corrections (2/3) (qmk#8903) * Split HHKB to ANSI and JP layouts and Add VIA support for each (qmk#8582) * Audio enable corrections (Part 4) (qmk#8974) * Fix typo from PR7114 (qmk#9171) * Augment future branch Changelogs (qmk#8978) * Revert "Branch point for 2020 May 30 Breaking Change"

zvecr added enhancement core labels Feb 29, 2020

zvecr requested a review from a team February 29, 2020 10:47

zvecr mentioned this pull request Feb 29, 2020

Switch to nano specs on ChibiOS builds #8270

Merged

13 tasks

zvecr added the breaking_change Changes that need to wait for a version increment label Feb 29, 2020

Boettner-eric approved these changes Mar 1, 2020

View reviewed changes

zvecr force-pushed the feature/mpaland_printf branch from 3d04d58 to 3bb07d4 Compare March 1, 2020 02:25

zvecr force-pushed the feature/mpaland_printf branch from 3bb07d4 to 360af10 Compare March 1, 2020 18:59

zvecr force-pushed the feature/mpaland_printf branch from 402b2c9 to aa40444 Compare March 12, 2020 23:49

zvecr marked this pull request as ready for review March 12, 2020 23:56

tzarc added the future_2020q2 label Mar 21, 2020

zvecr added 6 commits March 21, 2020 22:34

Refactor to use mpaland/printf

b9a6d13

trim firmware size

ca8df5e

remove keymap changes

a36fe6a

run clang format

b4e4db7

Fixup after rebase

4cb03fb

fix up git-submodule command for printf

d292ffe

zvecr force-pushed the feature/mpaland_printf branch from aa40444 to d292ffe Compare March 21, 2020 22:35

noroadsleft approved these changes May 4, 2020

View reviewed changes

noroadsleft merged commit e17b55e into qmk:master May 4, 2020

skullydazed added a commit that referenced this pull request May 4, 2020

Revert "Fix conflicting types for 'tfp_printf' (#8269)"

6f30b40

This reverts commit e17b55e.

skullydazed pushed a commit that referenced this pull request May 4, 2020

Fix conflicting types for 'tfp_printf' (#8269)

36496c5

* Refactor to use mpaland/printf * trim firmware size * remove keymap changes * run clang format * Fixup after rebase * fix up git-submodule command for printf

zvecr mentioned this pull request May 30, 2020

Add printf submodule as ChibiOS build dependency qmk/qmk_compiler#69

Merged

turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020

Revert "Fix conflicting types for 'tfp_printf' (qmk#8269)"

5c72a4a

This reverts commit e17b55e.

jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020

Revert "Fix conflicting types for 'tfp_printf' (qmk#8269)"

02039d5

This reverts commit e17b55e.

sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021

Revert "Fix conflicting types for 'tfp_printf' (qmk#8269)"

10e3bec

This reverts commit e17b55e.

BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024

Revert "Fix conflicting types for 'tfp_printf' (qmk#8269)"

a1e829a

This reverts commit 9abf176.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix conflicting types for 'tfp_printf' #8269

Fix conflicting types for 'tfp_printf' #8269

zvecr commented Feb 29, 2020 •

edited

Loading

drashna commented Mar 1, 2020

Boettner-eric commented Mar 1, 2020

drashna commented Mar 1, 2020

tzarc commented Mar 1, 2020

Boettner-eric left a comment

zvecr commented Mar 1, 2020 •

edited

Loading

tzarc commented Mar 1, 2020 •

edited

Loading

noroadsleft left a comment

noroadsleft commented May 4, 2020

fauxpark commented May 4, 2020 •

edited

Loading

Fix conflicting types for 'tfp_printf' #8269

Fix conflicting types for 'tfp_printf' #8269

Conversation

zvecr commented Feb 29, 2020 • edited Loading

Description

Types of Changes

Checklist

drashna commented Mar 1, 2020

Boettner-eric commented Mar 1, 2020

drashna commented Mar 1, 2020

tzarc commented Mar 1, 2020

Boettner-eric left a comment

Choose a reason for hiding this comment

zvecr commented Mar 1, 2020 • edited Loading

tzarc commented Mar 1, 2020 • edited Loading

noroadsleft left a comment

Choose a reason for hiding this comment

noroadsleft commented May 4, 2020

fauxpark commented May 4, 2020 • edited Loading

zvecr commented Feb 29, 2020 •

edited

Loading

zvecr commented Mar 1, 2020 •

edited

Loading

tzarc commented Mar 1, 2020 •

edited

Loading

fauxpark commented May 4, 2020 •

edited

Loading