VIA Support: KBD75 rev1/rev2 #8214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to have a different product id so users don't get confused when they're able to enable numpad layout on rev1 VIA
|
Build failure on yan's keymap =P |
drashna
approved these changes
Feb 21, 2020
zvecr
requested changes
Feb 21, 2020
Co-Authored-By: Joel Challis <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>
zvecr
approved these changes
Feb 21, 2020
|
Thanks! |
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
Feb 23, 2020
* add a VIA keymap for kbd75 * rev2 is a completely different pcb allowing a NEW layout, setting this to have a different product id so users don't get confused when they're able to enable numpad layout on rev1 VIA * Update keyboards/kbdfans/kbd75/rev1/config.h Co-Authored-By: Joel Challis <[email protected]> * Update keyboards/kbdfans/kbd75/rev2/config.h Co-Authored-By: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Feb 25, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (108 commits) `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236) [Keyboard] Add Wete (qmk#8229) Improvements to extrakey HID descriptors (qmk#8156) Hineybush h87a lock indicators (qmk#8237) Add VIA support for Prime_L (qmk#8233) Hub16 - Bug removal + clean up code (qmk#8227) [Keyboard] ai03 Equinox (qmk#8224) [Keyboard] Add zfrontier/big_switch (qmk#8205) Gingham Update (qmk#8225) A proper `send_string()` for the Unicode feature (qmk#8155) Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173) Add mouse support to SEND_STRING (qmk#8223) Add link to "Useful functions" in macro docs (qmk#7446) New functionality for cformat (qmk#7893) Update main.c (qmk#8198) format code according to conventions [skip ci] Fix QWIIC OLED for AVR (qmk#7769) VIA Support: KBD75 rev1/rev2 (qmk#8214) Update TMOv2 for new key (qmk#7759) Added custom keymap for preonic (qmk#7548) ...
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Mar 5, 2020
* add a VIA keymap for kbd75 * rev2 is a completely different pcb allowing a NEW layout, setting this to have a different product id so users don't get confused when they're able to enable numpad layout on rev1 VIA * Update keyboards/kbdfans/kbd75/rev1/config.h Co-Authored-By: Joel Challis <[email protected]> * Update keyboards/kbdfans/kbd75/rev2/config.h Co-Authored-By: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
* add a VIA keymap for kbd75 * rev2 is a completely different pcb allowing a NEW layout, setting this to have a different product id so users don't get confused when they're able to enable numpad layout on rev1 VIA * Update keyboards/kbdfans/kbd75/rev1/config.h Co-Authored-By: Joel Challis <[email protected]> * Update keyboards/kbdfans/kbd75/rev2/config.h Co-Authored-By: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* add a VIA keymap for kbd75 * rev2 is a completely different pcb allowing a NEW layout, setting this to have a different product id so users don't get confused when they're able to enable numpad layout on rev1 VIA * Update keyboards/kbdfans/kbd75/rev1/config.h Co-Authored-By: Joel Challis <[email protected]> * Update keyboards/kbdfans/kbd75/rev2/config.h Co-Authored-By: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
jakeisnt
pushed a commit
to jakeisnt/qmk_firmware
that referenced
this pull request
Aug 20, 2020
* add a VIA keymap for kbd75 * rev2 is a completely different pcb allowing a NEW layout, setting this to have a different product id so users don't get confused when they're able to enable numpad layout on rev1 VIA * Update keyboards/kbdfans/kbd75/rev1/config.h Co-Authored-By: Joel Challis <[email protected]> * Update keyboards/kbdfans/kbd75/rev2/config.h Co-Authored-By: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding VIA support for rev1/rev2 of the KBD75.
The rev2 is a very similar PCB but it has one major change, in that it allows the numpad layout. Prior to this change, the VID and PID would be the same leading to VIA users being able to set a numpad layout without the PCB actually having that capability. This will confuse people. I've added
config.hfiles with PIDs to each rev directory to help mitigate this.Changes on VIA and on this firmware were tested by KlondikeBahr as I do not own any kbd75.
Types of Changes
Checklist