Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update ISP Flashing guide #8149

Merged
merged 3 commits into from
Mar 2, 2020
Merged

[Docs] Update ISP Flashing guide #8149

merged 3 commits into from
Mar 2, 2020

Conversation

drashna
Copy link
Member

@drashna drashna commented Feb 11, 2020

Description

Hopefully, clarify a lot of the process, and add additional, useful information to the guide.

Types of Changes

  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@drashna drashna requested review from a team and noroadsleft February 11, 2020 09:33
noroadsleft
noroadsleft requested changes Feb 11, 2020
View reviewed changes
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Show resolved Hide resolved
docs/isp_flashing_guide.md Show resolved Hide resolved
fauxpark
fauxpark requested changes Feb 11, 2020
View reviewed changes
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
@drashna @fauxpark @noroadsleft
Apply suggestions from code review
55c49db 
AKA why you shouldn't write docs at 2am

Co-Authored-By: fauxpark <[email protected]>
Co-Authored-By: James Young <[email protected]>
noroadsleft
noroadsleft approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@drashna drashna requested a review from a team February 11, 2020 21:56
@drashna drashna requested a review from a team February 12, 2020 19:39
tzarc
tzarc reviewed Feb 21, 2020
View reviewed changes
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
tzarc
tzarc approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small things, no strong preference to get the changes made, up to you.

@drashna drashna merged commit abd36de into master Mar 2, 2020
@drashna drashna deleted the docs/isp_flashing branch March 2, 2020 06:29
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 3, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
3bd02bc 
* 'master' of https://github.com/qmk/qmk_firmware: (37 commits)
  Update Hungarian keymap and add sendstring LUT (qmk#8220)
  Remove "ugly hack in usb_main.c" comments (qmk#8296)
  Update encoder functions for Iris VIA keymap (qmk#8295)
  Reduce PROGMEM usage for sendstring LUT (qmk#8109)
  [Docs] Update ISP Flashing guide (qmk#8149)
  Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243)
  Add onekey keymap for testing reset to bootloader. (qmk#8288)
  Get the direction right on the S75 encoder (qmk#8287)
  Prune out pure software pwm && custom driver && remove wrapping BACKLIGHT_PIN (qmk#8041)
  Make a fix to savage65 and tmov2 for via (qmk#8286)
  format code according to conventions [skip ci]
  Short term fix for conflicting types for 'tfp_printf' (qmk#8157)
  Fix recent clang-format breaking quantum.c (qmk#8282)
  format code according to conventions [skip ci]
  Remove duplicate BRTG case (qmk#8277)
  Clean up includes for glcdfont headers (qmk#7745)
  Fix the Breaking Changes doc again
  [Docs] translated 'feature_tap_dance.md' to japanese. (qmk#8137)
  PWM DMA based RGB Underglow for STM32 (qmk#7928)
  Add VIA support to Prime_M. Clean up all files (qmk#8247)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@drashna @fauxpark
@noroadsleft @HokieGeek
[Docs] Update ISP Flashing guide (qmk#8149)
a016f93 
* [Docs] Update ISP Flashing guide

* Apply suggestions from code review

AKA why you shouldn't write docs at 2am

Co-Authored-By: fauxpark <[email protected]>
Co-Authored-By: James Young <[email protected]>

* Update workding for planck-qmk-dfu

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Mar 5, 2020
Merge remote-tracking branch 'upstream/master'
4aeb119 
* upstream/master: (37 commits)
  Add RGB lighting through one of the free pins (qmk#8294)
  [Keymap] Adding the 4sStylZ xd75 (qmk#8285)
  YD60MQ refactor and Configurator layout support (qmk#8313)
  [Keyboard] Forget to ifdef Super16 led config (qmk#8314)
  [Keyboard] Switch to RGB Matrix for Super16 (qmk#8305)
  [Keymap] Keymap Update (qmk#8309)
  New Keyboard: SiddersKB Majbritt (Pronounced My Brit) (qmk#8260)
  [Keyboard] VIA Support: Tada68 (qmk#8289)
  [Keyboard] LFK78 refactor (qmk#7835)
  [Keymap] new userspace for ibnuda (qmk#8221)
  [Keymap] Add crd's equinox keymap (qmk#8251)
  [Keymap] Feature/alfrdmalr/keymap update (qmk#8174)
  Fix bootloader definition for namecard2x4 (qmk#8301)
  Update Hungarian keymap and add sendstring LUT (qmk#8220)
  Remove "ugly hack in usb_main.c" comments (qmk#8296)
  Update encoder functions for Iris VIA keymap (qmk#8295)
  Reduce PROGMEM usage for sendstring LUT (qmk#8109)
  [Docs] Update ISP Flashing guide (qmk#8149)
  Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243)
  Add onekey keymap for testing reset to bootloader. (qmk#8288)
  ...
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@drashna @fauxpark
@noroadsleft @c0psrul3
[Docs] Update ISP Flashing guide (qmk#8149)
d415a81 
* [Docs] Update ISP Flashing guide

* Apply suggestions from code review

AKA why you shouldn't write docs at 2am

Co-Authored-By: fauxpark <[email protected]>
Co-Authored-By: James Young <[email protected]>

* Update workding for planck-qmk-dfu

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@drashna @fauxpark
@noroadsleft @sowbug
[Docs] Update ISP Flashing guide (qmk#8149)
c4f6fa9 
* [Docs] Update ISP Flashing guide

* Apply suggestions from code review

AKA why you shouldn't write docs at 2am

Co-Authored-By: fauxpark <[email protected]>
Co-Authored-By: James Young <[email protected]>

* Update workding for planck-qmk-dfu

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@drashna @fauxpark
@noroadsleft @kujawakk
[Docs] Update ISP Flashing guide (qmk#8149)
9511fed 
* [Docs] Update ISP Flashing guide

* Apply suggestions from code review

AKA why you shouldn't write docs at 2am

Co-Authored-By: fauxpark <[email protected]>
Co-Authored-By: James Young <[email protected]>

* Update workding for planck-qmk-dfu

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@drashna @fauxpark
@noroadsleft @jakeisnt
[Docs] Update ISP Flashing guide (qmk#8149)
27f24c4 
* [Docs] Update ISP Flashing guide

* Apply suggestions from code review

AKA why you shouldn't write docs at 2am

Co-Authored-By: fauxpark <[email protected]>
Co-Authored-By: James Young <[email protected]>

* Update workding for planck-qmk-dfu

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna @fauxpark @noroadsleft
[Docs] Update ISP Flashing guide (qmk#8149)
ce8e809 
* [Docs] Update ISP Flashing guide

* Apply suggestions from code review

AKA why you shouldn't write docs at 2am

Co-Authored-By: fauxpark <[email protected]>
Co-Authored-By: James Young <[email protected]>

* Update workding for planck-qmk-dfu

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drashna @tzarc @fauxpark @noroadsleft