Rename Polaris Tsangan layout to 60_tsangan_hhkb and enable community layout support #8144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Feb 11, 2020
zvecr
approved these changes
Feb 11, 2020
noroadsleft
approved these changes
Feb 11, 2020
|
Thanks! |
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
… layout support (qmk#8144) * Rename Polaris Tsangan layout to 60_tsangan_hhkb
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
… layout support (qmk#8144) * Rename Polaris Tsangan layout to 60_tsangan_hhkb
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
… layout support (qmk#8144) * Rename Polaris Tsangan layout to 60_tsangan_hhkb
jakeisnt
pushed a commit
to jakeisnt/qmk_firmware
that referenced
this pull request
Aug 20, 2020
… layout support (qmk#8144) * Rename Polaris Tsangan layout to 60_tsangan_hhkb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Polaris PCB has a Tsangan layout macro that matches the existing
60_tsangan_hhkblayout. I'm just renaming the layout macro to use that name so existing community layouts work. AFAIK these boards haven't shipped to anyone yet, so I don't think this is a breaking change since there is no hardware in the wild to break.I ran
make ai03/polarisand everything seems happy, except that yanfali's community layout firmware is too big (unrelated to this change).@ai03-2725, are you okay with this change?
Types of Changes
Issues Fixed or Closed by This PR
None.
Checklist