Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor minidox to use split_common #7924

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Refactor minidox to use split_common #7924

merged 2 commits into from
Jan 29, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 17, 2020 •
edited
Loading

Description

Mostly so that CTPC works on the arm split branch.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Jan 17, 2020
@zvecr zvecr requested a review from a team January 17, 2020 18:32
noroadsleft
noroadsleft approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@drashna
Copy link
Member

drashna commented Jan 18, 2020

@That-Canadian any objections (since you're listed as the maintainer)?

nooges
nooges approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@nooges nooges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on Canadian’s behalf

@nooges nooges merged commit 1249594 into qmk:master Jan 29, 2020
@fauxpark fauxpark mentioned this pull request Feb 4, 2020
Merged
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@zvecr @HokieGeek
Refactor minidox to use split_common (qmk#7924)
ca6aa62 
* Initial refactor of minidox to split_common

* post rebase fixes
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@zvecr @c0psrul3
Refactor minidox to use split_common (qmk#7924)
5934731 
* Initial refactor of minidox to split_common

* post rebase fixes
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@zvecr @kujawakk
Refactor minidox to use split_common (qmk#7924)
6f1d4cd 
* Initial refactor of minidox to split_common

* post rebase fixes
@zvecr zvecr deleted the feature/minidox_split_common branch April 28, 2020 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nooges nooges nooges approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zvecr @drashna @nooges @fauxpark @noroadsleft