Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dawn60 bug fix [URGENT] #7881

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Dawn60 bug fix [URGENT] #7881

merged 1 commit into from
Jan 13, 2020

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Jan 13, 2020 •
edited
Loading

Description

Place in VIA_EEPROM_CUSTOM_CONFIG_SIZE and clean up defines.

URGENT since the bug breaks the functionality of the board

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Dawn60 VIA EEPROM clobbering keymap EEPROM

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Xelus22 Xelus22 changed the title Dawn60 bug fix Dawn60 bug fix [URGENT] Jan 13, 2020
@fauxpark fauxpark requested a review from a team January 13, 2020 12:40
noroadsleft
noroadsleft approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 1034df5 into qmk:master Jan 13, 2020
@noroadsleft
Copy link
Member

Thanks!

HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@Xelus22 @HokieGeek
[Keyboard] Dawn60 bug fix [URGENT] (qmk#7881)
b52f529
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@Xelus22 @kujawakk
[Keyboard] Dawn60 bug fix [URGENT] (qmk#7881)
b6724b4
@Xelus22 Xelus22 deleted the dawn60_proper branch June 2, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xelus22 @noroadsleft @fauxpark