Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Allison Numpad #7823

Merged
merged 2 commits into from
Jan 8, 2020
Merged

add Allison Numpad #7823

merged 2 commits into from
Jan 8, 2020

Conversation

yiancar
Copy link
Contributor

@yiancar yiancar commented Jan 7, 2020 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr reviewed Jan 7, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could support the ortho_6x4 community layout here

keyboards/allison_numpad/info.json Outdated Show resolved Hide resolved
keyboards/allison_numpad/allison_numpad.h Outdated Show resolved Hide resolved
keyboards/allison_numpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/allison_numpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/allison_numpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/allison_numpad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/allison_numpad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/allison_numpad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/allison_numpad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/allison_numpad/rules.mk Show resolved Hide resolved
@zvecr zvecr added the keyboard label Jan 7, 2020
@zvecr zvecr requested a review from a team January 7, 2020 21:53
@yiancar
Copy link
Contributor Author

yiancar commented Jan 7, 2020

This should do it!

@drashna drashna merged commit 4a09679 into qmk:master Jan 8, 2020
@yiancar yiancar deleted the allison_numpad branch January 8, 2020 23:20
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@yiancar @HokieGeek
[Keyboard] add Allison Numpad (qmk#7823)
36293d1 
* add Allison Numpad

* alternative layout
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@yiancar @kujawakk
[Keyboard] add Allison Numpad (qmk#7823)
3ff4cda 
* add Allison Numpad

* alternative layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiancar @drashna @fauxpark @zvecr