Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Crkbd layout for bcat #7716

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Initial Crkbd layout for bcat #7716

merged 1 commit into from
Dec 26, 2019

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Dec 25, 2019

Description

Basically just my Lily58 layout with the number row chopped off. (Also, man, those SMD RGB LEDs are a PITA. But they seem to work, so yay!)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna approved these changes Dec 25, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drashna drashna requested a review from a team December 25, 2019 19:23
@drashna drashna added the keymap label Dec 25, 2019
@zvecr
Copy link
Member

zvecr commented Dec 26, 2019

Thanks!

@zvecr zvecr merged commit 12baca1 into qmk:master Dec 26, 2019
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@bcat @patrl
Initial Crkbd layout (qmk#7716)
14e7dff
@bcat bcat deleted the bcat_crkbd branch January 6, 2020 03:03
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@bcat @HokieGeek
Initial Crkbd layout (qmk#7716)
ccebaf4
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@bcat @kujawakk
Initial Crkbd layout (qmk#7716)
a47b947
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@bcat @zvecr
Initial Crkbd layout (qmk#7716)
de6cd21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcat @zvecr @drashna @fauxpark