Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby influenced Redox keymap #7531

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

eightbitraptor
Copy link
Contributor

Add a new keymap for the Redox split keyboard.

Description

I've been using this layout for a few weeks now and it's pretty stable. This layout has been influenced by the frequency of which certain characters appear in the two largest Ruby codebases I work with - the most frequently used symbols are all available generally without the use of modifer keys.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@eightbitraptor eightbitraptor changed the title Redox layout Ruby influenced Redox layout Dec 2, 2019
@noroadsleft noroadsleft requested a review from a team December 2, 2019 18:44
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the enum thing. looks good!

@drashna
Copy link
Member

drashna commented Dec 2, 2019

Just a heads up, you don't need to amend the commit. For keymaps, we always squash the commits when merging, so you can feel free to add a bunch of commits to it.

Either way is fine, but just wanted to let you know. :)

@noroadsleft noroadsleft changed the title Ruby influenced Redox layout Ruby influenced Redox keymap Dec 2, 2019
@noroadsleft noroadsleft merged commit 75c8a79 into qmk:master Dec 2, 2019
@noroadsleft
Copy link
Member

Thanks!

Just as an aside, QMK uses "layout" to describe the physical layout (where the keys are, and what their sizes are), and "keymap" to describe the logical layout (what happens when you use a key).

@eightbitraptor
Copy link
Contributor Author

@noroadsleft @drashna Thanks for the feedback folks ❤️ 🙏 Will bear it in mind next time

ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants