Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add keyboard Getta25 #7497

Merged
merged 15 commits into from
Jan 20, 2020
Merged

[Keyboard] Add keyboard Getta25 #7497

merged 15 commits into from
Jan 20, 2020

Conversation

Salicylic-acid3
Copy link
Contributor

Add Getta25 keyboard.

A 25 keys Tenkey.
Salicylic-acid3

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Salicylic-acid3
[Keyboard] Add keyboard Getta25
51274e9 
Add Getta25 keyboard.

A 25 keys Tenkey.
Salicylic-acid3
@stale
Copy link

stale bot commented Jan 11, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

noroadsleft
noroadsleft requested changes Jan 11, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this didn't get reviewed promptly!

keyboards/getta25/info.json Outdated Show resolved Hide resolved
keyboards/getta25/readme.md Outdated Show resolved Hide resolved
keyboards/getta25/readme.md Outdated Show resolved Hide resolved
keyboards/getta25/readme.md Outdated Show resolved Hide resolved
keyboards/getta25/info.json Outdated Show resolved Hide resolved
keyboards/getta25/info.json Show resolved Hide resolved
keyboards/getta25/info.json Outdated Show resolved Hide resolved
keyboards/getta25/info.json Show resolved Hide resolved
drashna
drashna requested changes Jan 13, 2020
View reviewed changes
keyboards/getta25/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/getta25/keymaps/oled/keymap.c Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Jan 13, 2020
View reviewed changes
keyboards/getta25/keymaps/oled/glcdfont.c Outdated Show resolved Hide resolved
keyboards/getta25/keymaps/oled/glcdfont.c Outdated Show resolved Hide resolved
Salicylic-acid3 and others added 11 commits January 14, 2020 21:26
@Salicylic-acid3 @noroadsleft
Update keyboards/getta25/info.json
64140ab 
Co-Authored-By: James Young <[email protected]>
@Salicylic-acid3 @noroadsleft
Update keyboards/getta25/readme.md
3ab68ac 
Co-Authored-By: James Young <[email protected]>
@Salicylic-acid3 @noroadsleft
Update keyboards/getta25/readme.md
32b39e4 
Co-Authored-By: James Young <[email protected]>
@Salicylic-acid3 @noroadsleft
Update keyboards/getta25/readme.md
5cc79a3 
Co-Authored-By: James Young <[email protected]>
@Salicylic-acid3 @noroadsleft
Update keyboards/getta25/info.json
1170fa3 
Co-Authored-By: James Young <[email protected]>
@Salicylic-acid3 @noroadsleft
Update keyboards/getta25/info.json
df00ec1 
Co-Authored-By: James Young <[email protected]>
@Salicylic-acid3 @noroadsleft
Update keyboards/getta25/info.json
b716594 
Co-Authored-By: James Young <[email protected]>
@Salicylic-acid3 @noroadsleft
Update keyboards/getta25/info.json
8ad0ee4 
Co-Authored-By: James Young <[email protected]>
@Salicylic-acid3 @fauxpark
Update keyboards/getta25/keymaps/oled/glcdfont.c
7a1c64f 
Co-Authored-By: fauxpark <[email protected]>
@Salicylic-acid3 @fauxpark
Update keyboards/getta25/keymaps/oled/glcdfont.c
69840ed 
Co-Authored-By: fauxpark <[email protected]>
@Salicylic-acid3
Keymap Update
d10d39b 
Remove unnecessary code blocks
fauxpark
fauxpark requested changes Jan 14, 2020
View reviewed changes
keyboards/getta25/keymaps/oled/keymap.c Outdated Show resolved Hide resolved
keyboards/getta25/keymaps/oled/keymap.c Outdated Show resolved Hide resolved
keyboards/getta25/keymaps/oled/keymap.c Outdated Show resolved Hide resolved
@Salicylic-acid3
Copy link
Contributor Author

Salicylic-acid3 commented Jan 20, 2020 •
edited
Loading

Any suggestions?

@noroadsleft
Copy link
Member

Nope.

@noroadsleft noroadsleft merged commit c23b735 into qmk:master Jan 20, 2020
@noroadsleft
Copy link
Member

Thanks!

HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@Salicylic-acid3 @HokieGeek
[Keyboard] Add keyboard Getta25 (qmk#7497)
26690d4 
* [Keyboard] Add keyboard Getta25

Add Getta25 keyboard.

A 25 keys Tenkey.
Salicylic-acid3

* Update keyboards/getta25/info.json

* Update keyboards/getta25/readme.md

* Update keyboards/getta25/readme.md

* Update keyboards/getta25/readme.md

* Update keyboards/getta25/info.json

* Update keyboards/getta25/info.json

* Update keyboards/getta25/info.json

* Update keyboards/getta25/info.json

* Update keyboards/getta25/keymaps/oled/glcdfont.c

* Update keyboards/getta25/keymaps/oled/glcdfont.c

* Keymap Update

Remove unnecessary code blocks

* Update keyboards/getta25/keymaps/oled/keymap.c

* Update keyboards/getta25/keymaps/oled/keymap.c

* Update keyboards/getta25/keymaps/oled/keymap.c
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@Salicylic-acid3 @kujawakk
[Keyboard] Add keyboard Getta25 (qmk#7497)
0b2d01b 
* [Keyboard] Add keyboard Getta25

Add Getta25 keyboard.

A 25 keys Tenkey.
Salicylic-acid3

* Update keyboards/getta25/info.json

* Update keyboards/getta25/readme.md

* Update keyboards/getta25/readme.md

* Update keyboards/getta25/readme.md

* Update keyboards/getta25/info.json

* Update keyboards/getta25/info.json

* Update keyboards/getta25/info.json

* Update keyboards/getta25/info.json

* Update keyboards/getta25/keymaps/oled/glcdfont.c

* Update keyboards/getta25/keymaps/oled/glcdfont.c

* Keymap Update

Remove unnecessary code blocks

* Update keyboards/getta25/keymaps/oled/keymap.c

* Update keyboards/getta25/keymaps/oled/keymap.c

* Update keyboards/getta25/keymaps/oled/keymap.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Salicylic-acid3 @noroadsleft @drashna @fauxpark @mechmerlin