Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add a new keyboard Chidori. #7496

Merged
merged 27 commits into from
Feb 5, 2020
Merged

[Keyboard] Add a new keyboard Chidori. #7496

merged 27 commits into from
Feb 5, 2020

Conversation

ka2hiro
Copy link
Contributor

@ka2hiro ka2hiro commented Nov 27, 2019

Description

Add a new keyboard Chidori to qmk.
Yet another split keyboard made with only through-hole components.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ka2hiro
Copy link
Contributor Author

ka2hiro commented Jan 30, 2020

@noroadsleft
Hello, Is there anything I can do to get this PR reviewed?

@noroadsleft
Copy link
Member

@ka2hiro Sorry, I labeled it but forgot to tag anyone.

Split keyboards aren't my area of expertise at all, but I'll review what I can.

noroadsleft
noroadsleft requested changes Jan 30, 2020
View reviewed changes
keyboards/chidori/chidori.c Outdated Show resolved Hide resolved
keyboards/chidori/info.json Show resolved Hide resolved
keyboards/chidori/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/chidori/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/chidori/chidori.h Outdated Show resolved Hide resolved
keyboards/chidori/rules.mk Outdated Show resolved Hide resolved
keyboards/chidori/rules.mk Outdated Show resolved Hide resolved
keyboards/chidori/rules.mk Outdated Show resolved Hide resolved
keyboards/chidori/rules.mk Outdated Show resolved Hide resolved
keyboards/chidori/rules.mk Show resolved Hide resolved
@noroadsleft noroadsleft requested review from drashna, fauxpark and a team January 30, 2020 21:30
ka2hiro and others added 21 commits February 1, 2020 05:29
@ka2hiro @noroadsleft
Update keyboards/chidori/info.json
eafb110 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/keymaps/default/keymap.c
c75d169 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/chidori.h
64fbaf1 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/keymaps/extended/keymap.c
c1b135d 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/keymaps/extended/keymap.c
413533a 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/keymaps/extended/keymap.c
833001b 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/keymaps/extended/keymap.c
073e275 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/keymaps/extended/keymap.c
192b41e 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/keymaps/extended/keymap.c
a25655b 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/keymaps/extended/keymap.c
6eb2989 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/readme.md
048f313 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/readme.md
3a5cb07 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/readme.md
dfbb783 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/readme.md
b8f09f9 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/rules.mk
8f266e6 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/rules.mk
30246ed 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/rules.mk
cb1fca4 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/rules.mk
92aaab8 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/rules.mk
c330a37 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/rules.mk
a4929f7 
Co-Authored-By: James Young <[email protected]>
@ka2hiro @noroadsleft
Update keyboards/chidori/rules.mk
5babb68 
Co-Authored-By: James Young <[email protected]>
@ka2hiro
Copy link
Contributor Author

ka2hiro commented Feb 1, 2020

@noroadsleft
Thank you for your prompt response!
I fixed all you pointed out.

@drashna drashna requested a review from a team February 5, 2020 03:45
@noroadsleft noroadsleft merged commit aed18a5 into qmk:master Feb 5, 2020
@noroadsleft
Copy link
Member

Thanks!

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 5, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
322b5bf 
* 'master' of https://github.com/qmk/qmk_firmware: (313 commits)
  [Keyboard] Add a new keyboard Chidori. (qmk#7496)
  Reduce SPLIT_USB_TIMEOUT by 500ms (qmk#7637)
  [Keyboard] Refactor deltasplit75 to use split_common (qmk#8083)
  Add RESET key for default keymap in Satisfaction 75 (qmk#8088)
  Relocate grave keycode processing (qmk#8082)
  [Keyboard] LFKPad refactor (qmk#8079)
  Remove entries for Minidox eep files from gitignore (qmk#8077)
  Add Midi Endpoint task to ChibiOS main (qmk#8071)
  Encoder brush size (qmk#8087)
  ridingqwerty: userspace update (qmk#8076)
  Ninjonas userspace (qmk#8070)
  Merlin's userspace updates (qmk#8074)
  Improve the functionality of qmk.questions (qmk#8020)
  [Keymap] Add User Keymap for FC660C (qmk#8062)
  format code according to conventions [skip ci]
  Dedupe extrakey report struct, and send functions in V-USB & LUFA (qmk#7993)
  Fix cformat processing files within ignore folders (qmk#8063)
  Update dirty submodule make message (qmk#8065)
  [Docs] future branch housekeeping
  format code according to conventions [skip ci]
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@ka2hiro @HokieGeek
[Keyboard] Add a new keyboard Chidori. (qmk#7496)
b74f40e 
* [Keyboard] Add a new keyboard Chidori.

* Update keyboards/chidori/info.json

* Update keyboards/chidori/keymaps/default/keymap.c

* Update keyboards/chidori/chidori.h

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update rules.mk

* Delete unnecesarry lines.

* Changes layer keys handing.
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@ka2hiro @c0psrul3
[Keyboard] Add a new keyboard Chidori. (qmk#7496)
72e6845 
* [Keyboard] Add a new keyboard Chidori.

* Update keyboards/chidori/info.json

* Update keyboards/chidori/keymaps/default/keymap.c

* Update keyboards/chidori/chidori.h

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update rules.mk

* Delete unnecesarry lines.

* Changes layer keys handing.
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@ka2hiro @kujawakk
[Keyboard] Add a new keyboard Chidori. (qmk#7496)
05c8c77 
* [Keyboard] Add a new keyboard Chidori.

* Update keyboards/chidori/info.json

* Update keyboards/chidori/keymaps/default/keymap.c

* Update keyboards/chidori/chidori.h

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/keymaps/extended/keymap.c

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/readme.md

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update keyboards/chidori/rules.mk

* Update rules.mk

* Delete unnecesarry lines.

* Changes layer keys handing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
awaiting review keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ka2hiro @noroadsleft @drashna