Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CR when computing BOOTLOADER_SIZE. #7453

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Remove CR when computing BOOTLOADER_SIZE. #7453

merged 1 commit into from
Nov 23, 2019

Conversation

elfmimi
Copy link
Contributor

@elfmimi elfmimi commented Nov 23, 2019 •
edited by noroadsleft
Loading

Description

In cygwin, calculation of BOOTLOADER_SIZE fails because of CR character passed-out by avr-gcc.
Here, avr-gcc originates to the binary package distributed by Microchip.
I'm using cygwin as my default working terminal and fixing this little issue clears the way.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@elfmimi elfmimi changed the title Remove CR(0x0D) when computing BOOTLOADER_SIZE. (for cygwin) Remove CR when computing BOOTLOADER_SIZE. Nov 23, 2019
@noroadsleft noroadsleft requested a review from a team November 23, 2019 05:37
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit 7874f29 into qmk:master Nov 23, 2019
noroadsleft pushed a commit that referenced this pull request Dec 2, 2019
@umi-umi @mtei
@shelaf @noroadsleft
[Docs] add japanese translations (#7454)
da1a527 
* for initial commit

* for initial commit

* for initial commit

* Update led_update_kb example (#7451)

* Update led_update_kb example

* Update comment to explain pin behavior

* wordsmith

* wordsmithing 2

* Remove CR when computing BOOTLOADER_SIZE. (#7453)

* Set up language fallback for docs, and update translation guidelines (#7403)

* Set up language fallback for docs, and update translation guidelines

* Title Case

* Add ID example

* Link to emoji flag cheatsheet

* Move docs preview section to contributing.md

* Point to docs preview in the readme

* [Keyboard] Added Cans12er keyboard (#7455)

* added cans12er keyboard

* updated readme

Updated the readme to conform with the provided template from the qmk_firmware githubpage

* Update keyboards/cans12er/README.md

Co-Authored-By: James Young <[email protected]>

* Changed configuration

Changed the configuration based on the Change Request from PR #7455 made by github user noroadsleft

* [Keyboard] Update ATmega32A readme files to match template (#7462)

* Update atmega32a readme files to match template

* Update atmega32a readme files to match template - fixes

* Apply suggestions from code review

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

Co-Authored-By: Takeshi ISHII <[email protected]>
Co-Authored-By: shela <[email protected]>
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@elfmimi
Remove CR when computing BOOTLOADER_SIZE. (qmk#7453)
c47ece1
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@umi-umi @mtei @shelaf
[Docs] add japanese translations (qmk#7454)
3dd6b7a 
* for initial commit

* for initial commit

* for initial commit

* Update led_update_kb example (qmk#7451)

* Update led_update_kb example

* Update comment to explain pin behavior

* wordsmith

* wordsmithing 2

* Remove CR when computing BOOTLOADER_SIZE. (qmk#7453)

* Set up language fallback for docs, and update translation guidelines (qmk#7403)

* Set up language fallback for docs, and update translation guidelines

* Title Case

* Add ID example

* Link to emoji flag cheatsheet

* Move docs preview section to contributing.md

* Point to docs preview in the readme

* [Keyboard] Added Cans12er keyboard (qmk#7455)

* added cans12er keyboard

* updated readme

Updated the readme to conform with the provided template from the qmk_firmware githubpage

* Update keyboards/cans12er/README.md

Co-Authored-By: James Young <[email protected]>

* Changed configuration

Changed the configuration based on the Change Request from PR qmk#7455 made by github user noroadsleft

* [Keyboard] Update ATmega32A readme files to match template (qmk#7462)

* Update atmega32a readme files to match template

* Update atmega32a readme files to match template - fixes

* Apply suggestions from code review

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

Co-Authored-By: Takeshi ISHII <[email protected]>
Co-Authored-By: shela <[email protected]>
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Dec 10, 2019
@elfmimi @drashna
Remove CR when computing BOOTLOADER_SIZE. (qmk#7453)
29d547d
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@elfmimi @patrl
Remove CR when computing BOOTLOADER_SIZE. (qmk#7453)
6f8fd87
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@umi-umi @mtei
@shelaf @patrl
[Docs] add japanese translations (qmk#7454)
5a25674 
* for initial commit

* for initial commit

* for initial commit

* Update led_update_kb example (qmk#7451)

* Update led_update_kb example

* Update comment to explain pin behavior

* wordsmith

* wordsmithing 2

* Remove CR when computing BOOTLOADER_SIZE. (qmk#7453)

* Set up language fallback for docs, and update translation guidelines (qmk#7403)

* Set up language fallback for docs, and update translation guidelines

* Title Case

* Add ID example

* Link to emoji flag cheatsheet

* Move docs preview section to contributing.md

* Point to docs preview in the readme

* [Keyboard] Added Cans12er keyboard (qmk#7455)

* added cans12er keyboard

* updated readme

Updated the readme to conform with the provided template from the qmk_firmware githubpage

* Update keyboards/cans12er/README.md

Co-Authored-By: James Young <[email protected]>

* Changed configuration

Changed the configuration based on the Change Request from PR qmk#7455 made by github user noroadsleft

* [Keyboard] Update ATmega32A readme files to match template (qmk#7462)

* Update atmega32a readme files to match template

* Update atmega32a readme files to match template - fixes

* Apply suggestions from code review

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

Co-Authored-By: Takeshi ISHII <[email protected]>
Co-Authored-By: shela <[email protected]>
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 6, 2020
@elfmimi @fdidron
Remove CR when computing BOOTLOADER_SIZE. (qmk#7453)
bf09fa6
@elfmimi elfmimi deleted the chomp-cr-for-cygwin branch February 4, 2020 03:39
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@elfmimi @HokieGeek
Remove CR when computing BOOTLOADER_SIZE. (qmk#7453)
15914e3
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@umi-umi @mtei
@shelaf @HokieGeek
[Docs] add japanese translations (qmk#7454)
d3eb6f2 
* for initial commit

* for initial commit

* for initial commit

* Update led_update_kb example (qmk#7451)

* Update led_update_kb example

* Update comment to explain pin behavior

* wordsmith

* wordsmithing 2

* Remove CR when computing BOOTLOADER_SIZE. (qmk#7453)

* Set up language fallback for docs, and update translation guidelines (qmk#7403)

* Set up language fallback for docs, and update translation guidelines

* Title Case

* Add ID example

* Link to emoji flag cheatsheet

* Move docs preview section to contributing.md

* Point to docs preview in the readme

* [Keyboard] Added Cans12er keyboard (qmk#7455)

* added cans12er keyboard

* updated readme

Updated the readme to conform with the provided template from the qmk_firmware githubpage

* Update keyboards/cans12er/README.md

Co-Authored-By: James Young <[email protected]>

* Changed configuration

Changed the configuration based on the Change Request from PR qmk#7455 made by github user noroadsleft

* [Keyboard] Update ATmega32A readme files to match template (qmk#7462)

* Update atmega32a readme files to match template

* Update atmega32a readme files to match template - fixes

* Apply suggestions from code review

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

Co-Authored-By: Takeshi ISHII <[email protected]>
Co-Authored-By: shela <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@elfmimi @fauxpark
Remove CR when computing BOOTLOADER_SIZE. (qmk#7453)
7bb66df
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@umi-umi @mtei
@shelaf @noroadsleft
[Docs] add japanese translations (qmk#7454)
3d7706e 
* for initial commit

* for initial commit

* for initial commit

* Update led_update_kb example (qmk#7451)

* Update led_update_kb example

* Update comment to explain pin behavior

* wordsmith

* wordsmithing 2

* Remove CR when computing BOOTLOADER_SIZE. (qmk#7453)

* Set up language fallback for docs, and update translation guidelines (qmk#7403)

* Set up language fallback for docs, and update translation guidelines

* Title Case

* Add ID example

* Link to emoji flag cheatsheet

* Move docs preview section to contributing.md

* Point to docs preview in the readme

* [Keyboard] Added Cans12er keyboard (qmk#7455)

* added cans12er keyboard

* updated readme

Updated the readme to conform with the provided template from the qmk_firmware githubpage

* Update keyboards/cans12er/README.md

Co-Authored-By: James Young <[email protected]>

* Changed configuration

Changed the configuration based on the Change Request from PR qmk#7455 made by github user noroadsleft

* [Keyboard] Update ATmega32A readme files to match template (qmk#7462)

* Update atmega32a readme files to match template

* Update atmega32a readme files to match template - fixes

* Apply suggestions from code review

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

* update files based on comments

Co-Authored-By: Takeshi ISHII <[email protected]>
Co-Authored-By: shela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elfmimi @fauxpark @zvecr @noroadsleft