Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kudox column-staggered layout. #7400

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Add Kudox column-staggered layout. #7400

merged 2 commits into from
Nov 19, 2019

Conversation

kumaokobo
Copy link
Contributor

Description

Add Kudox column-staggered layout.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 18, 2019 23:38
noroadsleft
noroadsleft requested changes Nov 19, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One teeny tiny thing...

keyboards/kudox/columner/info.json Outdated Show resolved Hide resolved
@kumaokobo
Copy link
Contributor Author

@noroadsleft Thank you for your reviewing!
I fixed the code pointed.

@noroadsleft
Copy link
Member

Thanks!

@noroadsleft noroadsleft merged commit bb87bde into qmk:master Nov 19, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@kumaokobo
[Keyboard] Add Kudox column-staggered layout. (qmk#7400)
db82489 
* Add Kudox columner layout.

* Remove an extra comma from info.json.
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@kumaokobo @patrl
[Keyboard] Add Kudox column-staggered layout. (qmk#7400)
755a341 
* Add Kudox columner layout.

* Remove an extra comma from info.json.
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@kumaokobo @HokieGeek
[Keyboard] Add Kudox column-staggered layout. (qmk#7400)
4088db7 
* Add Kudox columner layout.

* Remove an extra comma from info.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumaokobo @noroadsleft @drashna @fauxpark