Updated slave encoder sync to reduce dropped pulses #7325

XScorpion2 · 2019-11-10T22:51:41Z

Description

Fixes the slave encoder state syncing to reduce dropped pulses.

Types of Changes

Issues Fixed or Closed by This PR

Fixes Rotary encoder unresponsive on slave half of split keyboard #7055

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

splitkb · 2019-11-13T13:16:50Z

I've tested the code, and come to the following observations:

The code performs equally well on both halves now;
Both encoders now execute the code for one direction only, regardless of the direction you turn them. In my case, turning the encoder I assigned VOLU and VOLD to now performs VOLU for both directions.

splitkb · 2019-11-13T13:20:47Z

@drashna You said you have this code running on your Kyria too, do your observations match mine?

XScorpion2 · 2019-11-13T13:30:27Z

@splitkb Just pushed a fix for the direction issue. My bad, bad copy & paste.

splitkb · 2019-11-13T14:17:37Z

@XScorpion2 Are you sure the code is pushed? I've copied over the encoder code into my local encoder.c and executed make clean followed by make kyria:thomasbaart, which did recompile the file into my firmware. I still see the same behaviour as before.

XScorpion2 · 2019-11-13T14:27:58Z

Check now @splitkb 6b4f0a2

splitkb · 2019-11-13T14:43:36Z

It seems as though there's still the same problem, but now in the opposite direction. I did make clean and flashed both halves, for what it's worth, and used the code from your latest commit.

XScorpion2 · 2019-11-13T15:02:42Z

at work, will check again tonight

drashna · 2019-11-13T18:07:09Z

Yeah, that's the same issues that I was seeing, and can confirm that the changes don't fix it.

XScorpion2 · 2019-11-14T20:31:09Z

@splitkb @drashna Fixed and managed to find time to test it this time.

keyboards/rgbkb/sol/keymaps/xulkal/rules.mk

To make fauxpark happy Co-Authored-By: fauxpark <[email protected]>

splitkb · 2019-11-15T01:04:06Z

Confirmed to work, like a charm! Thank you very much for your efforts, @XScorpion2, it's much appreciated by myself and Kyria users!

drashna · 2019-11-15T04:09:55Z

Can also confirm that this fixes the issue.

However, it does not work on with #5998. But that's out of scope for this PR

drashna · 2019-11-15T05:25:09Z

Also, could the keyboard and keymap stuff be removed from the PR

XScorpion2 · 2019-11-15T13:07:32Z

@drashna fixed

* Updated slave encoder sync to reduce dropped pulses * Fixing encoder direction * Encoder behavior fixes, tested * Update keyboards/rgbkb/sol/keymaps/xulkal/rules.mk To make fauxpark happy Co-Authored-By: fauxpark <[email protected]> * Update custom_encoder.c * Update rules.mk

quantum/encoder.c

To allow for simple change of direction In fixing the Split Encoder issues in qmk#7325, the direction was flipped for all encoders. However, this flip actually corrects the direction to be correct, but this was an unintended change in behavior. Rather than reverting the dirction (because, now it's actually correctly processing CW vs CCW), lets add an option to flip this, so that users can revert to the older behavior if they want, without having to redefine the pins/pads.

* Updated slave encoder sync to reduce dropped pulses * Fixing encoder direction * Encoder behavior fixes, tested * Update keyboards/rgbkb/sol/keymaps/xulkal/rules.mk To make fauxpark happy Co-Authored-By: fauxpark <[email protected]> * Update custom_encoder.c * Update rules.mk

To allow for simple change of direction In fixing the Split Encoder issues in qmk#7325, the direction was flipped for all encoders. However, this flip actually corrects the direction to be correct, but this was an unintended change in behavior. Rather than reverting the dirction (because, now it's actually correctly processing CW vs CCW), lets add an option to flip this, so that users can revert to the older behavior if they want, without having to redefine the pins/pads.

* Add `ENCODER_DIRECTION_FLIP` setting To allow for simple change of direction In fixing the Split Encoder issues in #7325, the direction was flipped for all encoders. However, this flip actually corrects the direction to be correct, but this was an unintended change in behavior. Rather than reverting the dirction (because, now it's actually correctly processing CW vs CCW), lets add an option to flip this, so that users can revert to the older behavior if they want, without having to redefine the pins/pads. * Revert direction to old behavior * Make setting easier to read and understand * Use physically correct direction by default * Wordsmithing in documentation * Fix indenting in example * Add changelog

* Add `ENCODER_DIRECTION_FLIP` setting To allow for simple change of direction In fixing the Split Encoder issues in qmk#7325, the direction was flipped for all encoders. However, this flip actually corrects the direction to be correct, but this was an unintended change in behavior. Rather than reverting the dirction (because, now it's actually correctly processing CW vs CCW), lets add an option to flip this, so that users can revert to the older behavior if they want, without having to redefine the pins/pads. * Revert direction to old behavior * Make setting easier to read and understand * Use physically correct direction by default * Wordsmithing in documentation * Fix indenting in example * Add changelog

* Updated slave encoder sync to reduce dropped pulses * Fixing encoder direction * Encoder behavior fixes, tested * Update keyboards/rgbkb/sol/keymaps/xulkal/rules.mk To make fauxpark happy Co-Authored-By: fauxpark <[email protected]> * Update custom_encoder.c * Update rules.mk

* Add `ENCODER_DIRECTION_FLIP` setting To allow for simple change of direction In fixing the Split Encoder issues in qmk#7325, the direction was flipped for all encoders. However, this flip actually corrects the direction to be correct, but this was an unintended change in behavior. Rather than reverting the dirction (because, now it's actually correctly processing CW vs CCW), lets add an option to flip this, so that users can revert to the older behavior if they want, without having to redefine the pins/pads. * Revert direction to old behavior * Make setting easier to read and understand * Use physically correct direction by default * Wordsmithing in documentation * Fix indenting in example * Add changelog

* Add `ENCODER_DIRECTION_FLIP` setting To allow for simple change of direction In fixing the Split Encoder issues in #7325, the direction was flipped for all encoders. However, this flip actually corrects the direction to be correct, but this was an unintended change in behavior. Rather than reverting the dirction (because, now it's actually correctly processing CW vs CCW), lets add an option to flip this, so that users can revert to the older behavior if they want, without having to redefine the pins/pads. * Revert direction to old behavior * Make setting easier to read and understand * Use physically correct direction by default * Wordsmithing in documentation * Fix indenting in example * Add changelog

* Updated slave encoder sync to reduce dropped pulses * Fixing encoder direction * Encoder behavior fixes, tested * Update keyboards/rgbkb/sol/keymaps/xulkal/rules.mk To make fauxpark happy Co-Authored-By: fauxpark <[email protected]> * Update custom_encoder.c * Update rules.mk

Updated slave encoder sync to reduce dropped pulses

6b4f0a2

XScorpion2 mentioned this pull request Nov 10, 2019

Rotary encoder unresponsive on slave half of split keyboard #7055

Closed

3 tasks

drashna requested a review from a team November 11, 2019 21:48

Fixing encoder direction

2cd3d86

Encoder behavior fixes, tested

0987455

XScorpion2 marked this pull request as ready for review November 14, 2019 20:30

fauxpark requested changes Nov 14, 2019

View reviewed changes

keyboards/rgbkb/sol/keymaps/xulkal/rules.mk Outdated Show resolved Hide resolved

Update keyboards/rgbkb/sol/keymaps/xulkal/rules.mk

8627058

To make fauxpark happy Co-Authored-By: fauxpark <[email protected]>

noroadsleft added core enhancement keymap labels Nov 15, 2019

XScorpion2 added 2 commits November 15, 2019 07:06

Update custom_encoder.c

89bd362

Update rules.mk

41173d7

drashna approved these changes Nov 15, 2019

View reviewed changes

drashna requested a review from fauxpark November 15, 2019 18:12

drashna added the bug label Nov 15, 2019

drashna requested a review from a team November 15, 2019 18:12

drashna removed the keymap label Nov 15, 2019

jackhumbert approved these changes Nov 15, 2019

View reviewed changes

zvecr approved these changes Nov 15, 2019

View reviewed changes

drashna merged commit 0f0c73f into qmk:master Nov 15, 2019

ReVanTis reviewed Nov 18, 2019

View reviewed changes

quantum/encoder.c Show resolved Hide resolved

drashna mentioned this pull request Nov 19, 2019

Add ENCODER_DIRECTION_FLIP setting #7413

Closed

12 tasks

yanfali mentioned this pull request Nov 27, 2019

[Bug] Encoder support causing spamming on Iris Rev. 3 & 4 #7487

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated slave encoder sync to reduce dropped pulses #7325

Updated slave encoder sync to reduce dropped pulses #7325

XScorpion2 commented Nov 10, 2019 •

edited by noroadsleft

Loading

splitkb commented Nov 13, 2019

splitkb commented Nov 13, 2019

XScorpion2 commented Nov 13, 2019

splitkb commented Nov 13, 2019

XScorpion2 commented Nov 13, 2019 •

edited

Loading

splitkb commented Nov 13, 2019

XScorpion2 commented Nov 13, 2019

drashna commented Nov 13, 2019

XScorpion2 commented Nov 14, 2019

splitkb commented Nov 15, 2019

drashna commented Nov 15, 2019

drashna commented Nov 15, 2019

XScorpion2 commented Nov 15, 2019

Updated slave encoder sync to reduce dropped pulses #7325

Updated slave encoder sync to reduce dropped pulses #7325

Conversation

XScorpion2 commented Nov 10, 2019 • edited by noroadsleft Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

splitkb commented Nov 13, 2019

splitkb commented Nov 13, 2019

XScorpion2 commented Nov 13, 2019

splitkb commented Nov 13, 2019

XScorpion2 commented Nov 13, 2019 • edited Loading

splitkb commented Nov 13, 2019

XScorpion2 commented Nov 13, 2019

drashna commented Nov 13, 2019

XScorpion2 commented Nov 14, 2019

splitkb commented Nov 15, 2019

drashna commented Nov 15, 2019

drashna commented Nov 15, 2019

XScorpion2 commented Nov 15, 2019

XScorpion2 commented Nov 10, 2019 •

edited by noroadsleft

Loading

XScorpion2 commented Nov 13, 2019 •

edited

Loading