Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port SPLIT_USB_DETECT to crkbd #7195

Merged
merged 1 commit into from
Nov 16, 2019
Merged

Port SPLIT_USB_DETECT to crkbd #7195

merged 1 commit into from
Nov 16, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 29, 2019 •
edited
Loading

Description

While there are plans to move to split_common, that has complications as that currently has behaviour changes.

This PR adds SPLIT_USB_DETECT support for those users having issues with Elite-C V3s.

Tagging @foostan as maintainer.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Oct 29, 2019
@zvecr zvecr requested review from drashna and a team October 29, 2019 15:28
drashna
drashna approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm that it works

@drashna
Copy link
Member

drashna commented Oct 29, 2019

@foostan any objections to this change?

@zvecr zvecr marked this pull request as ready for review October 30, 2019 12:48
@foostan
Copy link
Contributor

foostan commented Nov 15, 2019

No problem. Thanks 👍

noroadsleft
noroadsleft approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__ ((weak)) ✔️

@zvecr
Copy link
Member Author

zvecr commented Nov 16, 2019

Thanks everyone!

@zvecr zvecr merged commit b94f6cb into qmk:master Nov 16, 2019
@stormbard stormbard mentioned this pull request Nov 17, 2019
Merged
13 tasks
@prog13
Copy link

prog13 commented Nov 19, 2019 •
edited
Loading

Hello everyone, bug report here.

This commit breaks RGB_MATRIX feature for me.

The slave half starts with the default mode (defined with RGB_MATRIX_STARTUP_MODE) and ignores any of RGB_* codes (RGB_MOD, RGB_TOG, etc).

I use EE_HANDS option and DFU bootloader. Tried to set master and slave halves explicitly, no luck. After dropping this particular commit, everything works as expected.

Should I open an issue?

@manna-harbour manna-harbour mentioned this pull request Nov 27, 2019
Closed
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@zvecr
Port SPLIT_USB_DETECT to crkbd (qmk#7195)
9151315
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@zvecr @patrl
Port SPLIT_USB_DETECT to crkbd (qmk#7195)
19bc43d
@zvecr zvecr mentioned this pull request Feb 6, 2020
Merged
13 tasks
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@zvecr @HokieGeek
Port SPLIT_USB_DETECT to crkbd (qmk#7195)
3ba6a5e
@zvecr zvecr deleted the feature/corne_usb_detect branch April 28, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zvecr @drashna @foostan @prog13 @noroadsleft