Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Keyboard Naked60 Update #7106

Merged
merged 5 commits into from
Oct 22, 2019
Merged

[Keyboard] Keyboard Naked60 Update #7106

merged 5 commits into from
Oct 22, 2019

Conversation

Salicylic-acid3
Copy link
Contributor

Support for SPLIT_KEYBOARD
Keymap updates

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Salicylic-acid3
[Keyboard] Keyboard Naked60 Update
163fa58 
Support for SPLIT_KEYBOARD
Keymap updates
drashna
drashna approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@drashna drashna requested a review from a team October 22, 2019 02:57
zvecr
zvecr requested changes Oct 22, 2019
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few suggestions though.

keyboards/naked60/readme.md Outdated Show resolved Hide resolved
keyboards/naked60/rev1/config.h Outdated Show resolved Hide resolved
keyboards/naked60/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/naked60/rev1/rev1.h Outdated Show resolved Hide resolved
@drashna drashna merged commit 737bca8 into qmk:master Oct 22, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@Salicylic-acid3 @zvecr
[Keyboard] Keyboard Naked60 Update (qmk#7106)
945508a 
* [Keyboard] Keyboard Naked60 Update

Support for SPLIT_KEYBOARD
Keymap updates

* Update keyboards/naked60/readme.md

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/naked60/rev1/config.h

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/naked60/rev1/rev1.h

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/naked60/rev1/rev1.h

Co-Authored-By: Joel Challis <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@Salicylic-acid3 @zvecr @HokieGeek
[Keyboard] Keyboard Naked60 Update (qmk#7106)
fb17044 
* [Keyboard] Keyboard Naked60 Update

Support for SPLIT_KEYBOARD
Keymap updates

* Update keyboards/naked60/readme.md

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/naked60/rev1/config.h

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/naked60/rev1/rev1.h

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/naked60/rev1/rev1.h

Co-Authored-By: Joel Challis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Salicylic-acid3 @drashna @zvecr