Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to my Lily58 keymap #7045

Merged
merged 7 commits into from
Oct 16, 2019
Merged

Various improvements to my Lily58 keymap #7045

merged 7 commits into from
Oct 16, 2019

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Oct 16, 2019

Description

Tweaks a bunch of things on the keymap based on day-to-day use. Also adds KLE images and a readme explaining some choices that went into the keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@bcat
Copy link
Contributor Author

bcat commented Oct 16, 2019

Test failures look to be unrelated (from the CLI tool?)

@zvecr zvecr added the keymap label Oct 16, 2019
@zvecr zvecr requested a review from a team October 16, 2019 14:53
@zvecr
Copy link
Member

zvecr commented Oct 16, 2019

The build scripts decided that everything had changed, so built all default keymaps for all keyboards, and didnt actually build yours, #7038 should hopefully fix that.

@drashna drashna merged commit 7662ee7 into qmk:master Oct 16, 2019
@drashna
Copy link
Member

drashna commented Oct 16, 2019

Thanks!

@bcat bcat deleted the bcat_lily58 branch October 17, 2019 04:32
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* Fix off-by-one error in Lily58 function keys

* Swap number and symbol layers

* Move grave/tilde to the left of brackets/braces

* Add KLE links

* Move function keys to Raise layer

* Move symbols nearer to home row

* Add readme for Lily58 layout
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* Fix off-by-one error in Lily58 function keys

* Swap number and symbol layers

* Move grave/tilde to the left of brackets/braces

* Add KLE links

* Move function keys to Raise layer

* Move symbols nearer to home row

* Add readme for Lily58 layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants