Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete note about media keys in MacOS #6631

Merged
merged 4 commits into from
Oct 29, 2019
Merged

Conversation

purcell
Copy link
Contributor

@purcell purcell commented Aug 29, 2019

KC_MNXT and KC_MPRV work fine on MacOS, so this note is obsolete.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

@fauxpark
Copy link
Member

Thanks!

Could you also update the keycode descriptions in keycodes.md and keycodes_basic.md, and remove the note at the top of the Media Keys section?

@drashna drashna requested a review from a team August 30, 2019 04:33
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above ^

KC_MNXT and KC_MPRV work fine on MacOS, so this note is obsolete.
@purcell
Copy link
Contributor Author

purcell commented Sep 8, 2019

Thanks, I've updated those other docs too - I'd made the initial edit by quickly editing the file in github, so getting around to checking out the branch and updating it took a little longer.

Note that I have left the MacOS-specific keycodes descriptions as-is: I might actually try updating my keymap to send those instead of MNXT/MPRV, just to see if they still work. It would be good to figure out (and note) with which MacOS versions they are necessary, if any.

@purcell
Copy link
Contributor Author

purcell commented Sep 8, 2019

Okay, I tried this out: MFFD and MRWD have the effect of skipping ahead/back within a track if held, or they skip the track if tapped. To that extent, they may be preferable to MNXT/MPRV for MacOS users. I think I might add a note to that effect in the Media Keys section, so maybe hold off on merging for a short time.

@fauxpark
Copy link
Member

fauxpark commented Sep 8, 2019

I didn't know that, cool! 😄

@purcell
Copy link
Contributor Author

purcell commented Sep 8, 2019

I've noted that in the Media Keys section now. :-)

docs/keycodes_basic.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team September 21, 2019 18:23
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zvecr zvecr requested a review from fauxpark October 28, 2019 18:44
docs/keycodes_basic.md Outdated Show resolved Hide resolved
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit 606813b into qmk:master Oct 29, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* Remove obsolete note about media keys in MacOS

KC_MNXT and KC_MPRV work fine on MacOS, so this note is obsolete.

* Document behaviour of MEDIA_FAST_FORWARD/MEDIA_REWIND codes on MacOS

* Small typo fix, and make OS-dependent keycode claim less absolute

* Update docs/keycodes_basic.md

Co-Authored-By: fauxpark <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* Remove obsolete note about media keys in MacOS

KC_MNXT and KC_MPRV work fine on MacOS, so this note is obsolete.

* Document behaviour of MEDIA_FAST_FORWARD/MEDIA_REWIND codes on MacOS

* Small typo fix, and make OS-dependent keycode claim less absolute

* Update docs/keycodes_basic.md

Co-Authored-By: fauxpark <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Remove obsolete note about media keys in MacOS

KC_MNXT and KC_MPRV work fine on MacOS, so this note is obsolete.

* Document behaviour of MEDIA_FAST_FORWARD/MEDIA_REWIND codes on MacOS

* Small typo fix, and make OS-dependent keycode claim less absolute

* Update docs/keycodes_basic.md

Co-Authored-By: fauxpark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants