Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OLED] Added support for CR #6399

Merged
merged 1 commit into from
Jul 27, 2019
Merged

[OLED] Added support for CR #6399

merged 1 commit into from
Jul 27, 2019

Conversation

XScorpion2
Copy link
Contributor

@XScorpion2 XScorpion2 commented Jul 24, 2019 •
edited
Loading

Description

Currently OLED Dirver only supports LF (\n) character in a string to clear out the rest of the current line and advance to the next line for writing. This PR adds support for CR (\r) character as well to advance to the next line, however not clear out the rest of the current line. This is extremely useful when you want to display a multi-line logo using a single array without wiping out exiting lines and flagging the OLED as dirty unnecessarily.

LF (\n):
"EX BUFFER L1"
"EX BUFFER L2"

oled_write("E1\nE2");

Result:
"E1          "
"E2 BUFFER L2"

CR (\r):
"EX BUFFER L1"
"EX BUFFER L2"

oled_write("E1\rE2");

Result:
"E1 BUFFER L1"
"E2 BUFFER L2"

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested review from a team July 24, 2019 01:41
@zvecr zvecr requested a review from a team July 25, 2019 23:04
@drashna drashna merged commit ec39545 into qmk:master Jul 27, 2019
duncanyoyo1 added a commit to duncanyoyo1/qmk_firmware that referenced this pull request Jul 28, 2019
@duncanyoyo1
Merge pull request #82 from qmk/master
598266b 
(OLED) Added support for CR (qmk#6399)
duncanyoyo1 added a commit to duncanyoyo1/qmk_firmware that referenced this pull request Jul 28, 2019
@duncanyoyo1
Merge pull request #83 from qmk/master
d56531c 
(OLED) Added support for CR (qmk#6399)
@XScorpion2 XScorpion2 deleted the feature/oled_cr_support branch August 1, 2019 01:12
raymond-w-ko pushed a commit to raymond-w-ko/qmk_firmware that referenced this pull request Aug 4, 2019
@XScorpion2 @raymond-w-ko
(OLED) Added support for CR (qmk#6399)
a97acc5 
Currently OLED Dirver only supports LF (\n) character in a string to clear out the rest of the current line and advance to the next line for writing. This PR adds support for CR (\r) character as well to advance to the next line, however not clear out the rest of the current line. This is extremely useful when you want to display a multi-line logo using a single array without wiping out exiting lines and flagging the OLED as dirty unnecessarily.
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Aug 8, 2019
@XScorpion2 @drashna
(OLED) Added support for CR (qmk#6399)
93a6b93 
Currently OLED Dirver only supports LF (\n) character in a string to clear out the rest of the current line and advance to the next line for writing. This PR adds support for CR (\r) character as well to advance to the next line, however not clear out the rest of the current line. This is extremely useful when you want to display a multi-line logo using a single array without wiping out exiting lines and flagging the OLED as dirty unnecessarily.
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Aug 13, 2019
@XScorpion2 @fdidron
(OLED) Added support for CR (qmk#6399)
986a0f0 
Currently OLED Dirver only supports LF (\n) character in a string to clear out the rest of the current line and advance to the next line for writing. This PR adds support for CR (\r) character as well to advance to the next line, however not clear out the rest of the current line. This is extremely useful when you want to display a multi-line logo using a single array without wiping out exiting lines and flagging the OLED as dirty unnecessarily.
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@XScorpion2 @doughsay
(OLED) Added support for CR (qmk#6399)
a238c86 
Currently OLED Dirver only supports LF (\n) character in a string to clear out the rest of the current line and advance to the next line for writing. This PR adds support for CR (\r) character as well to advance to the next line, however not clear out the rest of the current line. This is extremely useful when you want to display a multi-line logo using a single array without wiping out exiting lines and flagging the OLED as dirty unnecessarily.
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
@XScorpion2 @drashna
(OLED) Added support for CR (qmk#6399)
7a8a861 
Currently OLED Dirver only supports LF (\n) character in a string to clear out the rest of the current line and advance to the next line for writing. This PR adds support for CR (\r) character as well to advance to the next line, however not clear out the rest of the current line. This is extremely useful when you want to display a multi-line logo using a single array without wiping out exiting lines and flagging the OLED as dirty unnecessarily.
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@XScorpion2
(OLED) Added support for CR (qmk#6399)
e0a7273 
Currently OLED Dirver only supports LF (\n) character in a string to clear out the rest of the current line and advance to the next line for writing. This PR adds support for CR (\r) character as well to advance to the next line, however not clear out the rest of the current line. This is extremely useful when you want to display a multi-line logo using a single array without wiping out exiting lines and flagging the OLED as dirty unnecessarily.
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@XScorpion2 @drashna
(OLED) Added support for CR (qmk#6399)
50f41af 
Currently OLED Dirver only supports LF (\n) character in a string to clear out the rest of the current line and advance to the next line for writing. This PR adds support for CR (\r) character as well to advance to the next line, however not clear out the rest of the current line. This is extremely useful when you want to display a multi-line logo using a single array without wiping out exiting lines and flagging the OLED as dirty unnecessarily.
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@XScorpion2 @swamp09
(OLED) Added support for CR (qmk#6399)
787128a 
Currently OLED Dirver only supports LF (\n) character in a string to clear out the rest of the current line and advance to the next line for writing. This PR adds support for CR (\r) character as well to advance to the next line, however not clear out the rest of the current line. This is extremely useful when you want to display a multi-line logo using a single array without wiping out exiting lines and flagging the OLED as dirty unnecessarily.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@XScorpion2 @drashna
(OLED) Added support for CR (qmk#6399)
a405c1a 
Currently OLED Dirver only supports LF (\n) character in a string to clear out the rest of the current line and advance to the next line for writing. This PR adds support for CR (\r) character as well to advance to the next line, however not clear out the rest of the current line. This is extremely useful when you want to display a multi-line logo using a single array without wiping out exiting lines and flagging the OLED as dirty unnecessarily.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@XScorpion2 @drashna @zvecr @noroadsleft