Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling json files. #6340

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Fix compiling json files. #6340

merged 1 commit into from
Jul 15, 2019

Conversation

skullydazed
Copy link
Member

Description

Somehow I didn't notice these were broke before merging #6176. This is my PR of shame.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe time to add some quick execution tests to catch this kind of run time failure

@skullydazed skullydazed merged commit 7d557a0 into master Jul 15, 2019
@skullydazed skullydazed deleted the fix_python branch July 15, 2019 22:12
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jul 16, 2019
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jul 19, 2019
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants