Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Vagrant to use qmk_base_container #6194

Merged
merged 4 commits into from
Jul 16, 2019
Merged

Configure Vagrant to use qmk_base_container #6194

merged 4 commits into from
Jul 16, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 25, 2019 •
edited
Loading

Description

To help with environment predictability, this PR configures Vagrant to use qmk_base_container.

The process is as follows:

vagrant up

if using docker directly
  build a slightly modified qmk_base_container with ssh
  run container
else
  build Debian vm
  install docker
  pull qmk_base_container
  run container
  patch so that we jump directly to container instead of to vm

vagrant ssh

  Running inside qmk_base_container with the predicable toolchain

To an new/existing vagrant user, the change is transparent, and should not change the workflow.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@yanfali
Copy link
Contributor

yanfali commented Jun 25, 2019

So inception? 😆

yanfali
yanfali approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Will probably help with testing base image too

@zvecr zvecr changed the title Configure Vagrant to use qmk_base_container [WIP] Configure Vagrant to use qmk_base_container Jun 26, 2019
@zvecr
Copy link
Member Author

zvecr commented Jun 26, 2019 •
edited
Loading

Looks like there is an issue with restarting the VM, and the docker mount being empty. Will investigate and marked as WIP while i do so. Good to go again, also gave a quick once over of the docs.

@zvecr zvecr changed the title [WIP] Configure Vagrant to use qmk_base_container Configure Vagrant to use qmk_base_container Jun 26, 2019
drashna
drashna approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and pushes things in a more "QMK managed" direction.

@skullydazed skullydazed merged commit 29e9caa into qmk:master Jul 16, 2019
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jul 16, 2019
@zvecr @drashna
Configure Vagrant to use qmk_base_container (qmk#6194)
0033b79 
* Initial conversion of vagrant to use qmkfm/base_container

* Fix vagrant when using docker provider

* Workaround for VirtualBox VM restarts

* Generalise Vagrant docs slightly and add FAQ
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jul 19, 2019
@zvecr @fdidron
Configure Vagrant to use qmk_base_container (qmk#6194)
3acf64b 
* Initial conversion of vagrant to use qmkfm/base_container

* Fix vagrant when using docker provider

* Workaround for VirtualBox VM restarts

* Generalise Vagrant docs slightly and add FAQ
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@zvecr @doughsay
Configure Vagrant to use qmk_base_container (qmk#6194)
7c79bee 
* Initial conversion of vagrant to use qmkfm/base_container

* Fix vagrant when using docker provider

* Workaround for VirtualBox VM restarts

* Generalise Vagrant docs slightly and add FAQ
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
@zvecr @skullydazed
Configure Vagrant to use qmk_base_container (qmk#6194)
6005aae 
* Initial conversion of vagrant to use qmkfm/base_container

* Fix vagrant when using docker provider

* Workaround for VirtualBox VM restarts

* Generalise Vagrant docs slightly and add FAQ
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@zvecr
Configure Vagrant to use qmk_base_container (qmk#6194)
140beb6 
* Initial conversion of vagrant to use qmkfm/base_container

* Fix vagrant when using docker provider

* Workaround for VirtualBox VM restarts

* Generalise Vagrant docs slightly and add FAQ
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@zvecr @skullydazed
Configure Vagrant to use qmk_base_container (qmk#6194)
6409c94 
* Initial conversion of vagrant to use qmkfm/base_container

* Fix vagrant when using docker provider

* Workaround for VirtualBox VM restarts

* Generalise Vagrant docs slightly and add FAQ
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@zvecr @swamp09
Configure Vagrant to use qmk_base_container (qmk#6194)
18dd989 
* Initial conversion of vagrant to use qmkfm/base_container

* Fix vagrant when using docker provider

* Workaround for VirtualBox VM restarts

* Generalise Vagrant docs slightly and add FAQ
@zvecr zvecr deleted the feature/vagrant_base_container branch April 28, 2020 00:36
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr @skullydazed
Configure Vagrant to use qmk_base_container (qmk#6194)
9e52846 
* Initial conversion of vagrant to use qmkfm/base_container

* Fix vagrant when using docker provider

* Workaround for VirtualBox VM restarts

* Generalise Vagrant docs slightly and add FAQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanfali yanfali yanfali approved these changes

@drashna drashna drashna approved these changes

@skullydazed skullydazed skullydazed approved these changes

@algernon algernon Awaiting requested review from algernon

@fredizzimo fredizzimo Awaiting requested review from fredizzimo

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @yanfali @drashna @skullydazed