Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor userspace and Quefrency keymap fixes #6134

Merged
merged 2 commits into from
Jun 16, 2019
Merged

Minor userspace and Quefrency keymap fixes #6134

merged 2 commits into from
Jun 16, 2019

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Jun 15, 2019

Description

  • Fix typos in my userspace config
  • Remove Quefrency mouse keys layer I don't use

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

bcat added 2 commits June 15, 2019 17:46
@bcat
Fix typo for RGBLIGHT config values
9474a26 
It doesn't make a difference right now since these are the defaults in
rgblight.h (which I'm just setting explicitly since some of the keyboard
configs change these defaults). However, I'd rather be explicit, so
fixing my typo. :)
@bcat
Remove mouse keys layer from Quefrency keymap
9cf465f 
It's a fun idea, but I never use it in practice.
@bcat
Copy link
Contributor Author

bcat commented Jun 15, 2019

Continuous build failure seems unrelated.

noroadsleft
noroadsleft approved these changes Jun 16, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI errors are unrelated.

@drashna drashna merged commit 53a81fc into qmk:master Jun 16, 2019
@bcat bcat deleted the bcat_keebs branch June 16, 2019 17:38
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@bcat @Timbus
[Keymap] Minor userspace and Quefrency keymap fixes (qmk#6134)
0eecc12 
* Fix typo for RGBLIGHT config values

It doesn't make a difference right now since these are the defaults in
rgblight.h (which I'm just setting explicitly since some of the keyboard
configs change these defaults). However, I'd rather be explicit, so
fixing my typo. :)

* Remove mouse keys layer from Quefrency keymap

It's a fun idea, but I never use it in practice.
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@bcat @doughsay
[Keymap] Minor userspace and Quefrency keymap fixes (qmk#6134)
fb22eaa 
* Fix typo for RGBLIGHT config values

It doesn't make a difference right now since these are the defaults in
rgblight.h (which I'm just setting explicitly since some of the keyboard
configs change these defaults). However, I'd rather be explicit, so
fixing my typo. :)

* Remove mouse keys layer from Quefrency keymap

It's a fun idea, but I never use it in practice.
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@bcat @drashna
[Keymap] Minor userspace and Quefrency keymap fixes (qmk#6134)
5695af9 
* Fix typo for RGBLIGHT config values

It doesn't make a difference right now since these are the defaults in
rgblight.h (which I'm just setting explicitly since some of the keyboard
configs change these defaults). However, I'd rather be explicit, so
fixing my typo. :)

* Remove mouse keys layer from Quefrency keymap

It's a fun idea, but I never use it in practice.
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@bcat @JeffreyPalmer
[Keymap] Minor userspace and Quefrency keymap fixes (qmk#6134)
154c34c 
* Fix typo for RGBLIGHT config values

It doesn't make a difference right now since these are the defaults in
rgblight.h (which I'm just setting explicitly since some of the keyboard
configs change these defaults). However, I'd rather be explicit, so
fixing my typo. :)

* Remove mouse keys layer from Quefrency keymap

It's a fun idea, but I never use it in practice.
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@bcat @swamp09
[Keymap] Minor userspace and Quefrency keymap fixes (qmk#6134)
875d299 
* Fix typo for RGBLIGHT config values

It doesn't make a difference right now since these are the defaults in
rgblight.h (which I'm just setting explicitly since some of the keyboard
configs change these defaults). However, I'd rather be explicit, so
fixing my typo. :)

* Remove mouse keys layer from Quefrency keymap

It's a fun idea, but I never use it in practice.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@bcat @drashna
[Keymap] Minor userspace and Quefrency keymap fixes (qmk#6134)
608f032 
* Fix typo for RGBLIGHT config values

It doesn't make a difference right now since these are the defaults in
rgblight.h (which I'm just setting explicitly since some of the keyboard
configs change these defaults). However, I'd rather be explicit, so
fixing my typo. :)

* Remove mouse keys layer from Quefrency keymap

It's a fun idea, but I never use it in practice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcat @drashna @noroadsleft