Bootmagic does not actually work on BMC boards, removing from panc60 #5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/panc60_refactor
zvecr
reviewed
Apr 7, 2019
|
Bootmagic should work. Not sure why it wouldn't... |
danielo515
pushed a commit
to danielo515/qmk_firmware
that referenced
this pull request
May 15, 2019
…rom panc60 (qmk#5573) * remove unneeded uart setting * use pragma once everywhere * remove custom matrix support * fixup readme * set bootmagic to lite * remove dependency on custom i2c code * use the right header files and function calls * remove bootmagic support as it doesn't work on bmc boards * readme merge artifacts removal
shimesaba-type0
pushed a commit
to shimesaba-type0/qmk_firmware
that referenced
this pull request
Jun 22, 2019
…rom panc60 (qmk#5573) * remove unneeded uart setting * use pragma once everywhere * remove custom matrix support * fixup readme * set bootmagic to lite * remove dependency on custom i2c code * use the right header files and function calls * remove bootmagic support as it doesn't work on bmc boards * readme merge artifacts removal
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
…rom panc60 (qmk#5573) * remove unneeded uart setting * use pragma once everywhere * remove custom matrix support * fixup readme * set bootmagic to lite * remove dependency on custom i2c code * use the right header files and function calls * remove bootmagic support as it doesn't work on bmc boards * readme merge artifacts removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove bootmagic support on panc60 as it doesn't actually support it. Sigh....
Types of Changes
Checklist