Refactor E6V2 BMC PCB to get rid of custom i2c code in favor of QMK i2c_master #5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
…2c_master (qmk#5572) * remove custom i2c code in favor of QMK i2c_master * clean up config file * fix pyusb install instructions * fix naming in usbconfig.h * disable bootmagic as it does not work for bmc boards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor E6V2 BMC PCB to get rid of custom i2c code in favor of QMK i2c_master. In addition, did some other refactoring such as
Types of Changes
Checklist