Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V60 Type R - Turn on leds for Configurator + Refactor #5546

Merged
merged 8 commits into from
Apr 4, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Apr 3, 2019

Description

  • Turned on LEDs (RGB/Backlight) by default in rules.mk to allow Configurator users to fully use the features.
  • Updated to "latest" QMK formatting.
  • Update readme

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Apr 4, 2019

Default keymaps compile, Community keymaps are the issue.

Thanks!

@drashna drashna merged commit b463415 into qmk:master Apr 4, 2019
legooolas added a commit to legooolas/qmk_firmware that referenced this pull request Apr 5, 2019
* upstream/master: (445 commits)
  Update ps2avrgb template to use standard matrix/i2c code (qmk#4957)
  [Keyboard] Simplified handwired/xealous since most of the features are in core now. (qmk#5556)
  [Keyboard] Move scrabblepad into donutcables directory (qmk#5553)
  [Keymap] Additional RGB options set (qmk#5551)
  [Keyboard] Add Budget96 by Donut Cables (qmk#5550)
  [Keyboard] Added configurable defaults for RGB backlight parameters. (qmk#5549)
  Added Hacked Motospeed keyboard (qmk#5534)
  [Keymap] New HS60/v2 HHKB keymap for goatmaster (qmk#5545)
  [Keyboard] add treeadstone48 (qmk#5405)
  [Keyboard] Doro67 Multi PCB port (qmk#5539)
  [Keyboard] V60 Type R - Turn on leds for Configurator + Refactor (qmk#5546)
  RGB Matrix support for Massdrop CTRL/ALT (qmk#5328)
  Added encoder support to split common code (qmk#5477)
  Eager Per Row Debouncing added (added to Ergodox) (qmk#5498)
  Added configurable defaults for RGB backlight indicators.
  [Keyboard] Small Refactor of Duck boards (qmk#5521)
  [Keyboard] Quantrik Kyuu 65% Board (qmk#5541)
  Call default zeal60 rgb file
  remove call to custom rgb file
  Removed duplicated zeal60 files
  ...
@mechmerlin mechmerlin deleted the feature/v60 branch April 17, 2019 03:48
danielo515 pushed a commit to danielo515/qmk_firmware that referenced this pull request May 15, 2019
…#5546)

* use pragma once where applicable

* remove ?

* update default keymap readme

* remove un need include

* update readme with newbs guide

* set underglow and backlight to be on by default, and explicitly set them to no for the default keymap to handle the non Polestar case.

* put mine and benlyall's name in the code

* update readme
shimesaba-type0 pushed a commit to shimesaba-type0/qmk_firmware that referenced this pull request Jun 22, 2019
…#5546)

* use pragma once where applicable

* remove ?

* update default keymap readme

* remove un need include

* update readme with newbs guide

* set underglow and backlight to be on by default, and explicitly set them to no for the default keymap to handle the non Polestar case.

* put mine and benlyall's name in the code

* update readme
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
…#5546)

* use pragma once where applicable

* remove ?

* update default keymap readme

* remove un need include

* update readme with newbs guide

* set underglow and backlight to be on by default, and explicitly set them to no for the default keymap to handle the non Polestar case.

* put mine and benlyall's name in the code

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants