revert back to the old custom i2c code for bmc #5501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XScorpion2
reviewed
Mar 28, 2019
| @@ -57,7 +57,7 @@ void rgblight_set(void) { | |||
| } | |||
|
|
|||
| i2c_init(); | |||
| i2c_transmit(0xb0, (uint8_t*)led, 3 * RGBLED_NUM, 100); | |||
There was a problem hiding this comment.
Well, there's yer problem. You didn't shift the address before passing it in.
There was a problem hiding this comment.
I take that back, you are already using the shifted address
|
Curses. :( So, it's something weird then. If somebody wants to figure this out, it would be awesome. But for now, reverted. |
danielo515
pushed a commit
to danielo515/qmk_firmware
that referenced
this pull request
May 15, 2019
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@drashna deceived me and I willingly obeyed his lies regarding the usage of i2c_master over the custom i2c code needed for ps2avrgb. I suspect it was all part of his ploy to discredit and undermine my BMC ambitions.
In all seriousness, I'll have to take another look at i2c_master and see what exactly is causing it to mess up BMC boards making it not type ANYTHING. For the time being, reverting the change he requested.
Types of Changes
Issues Fixed or Closed by This PR
Checklist