Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HB85 Refactor/Layout Addition #5451

Merged
merged 12 commits into from
Mar 20, 2019
Merged

HB85 Refactor/Layout Addition #5451

merged 12 commits into from
Mar 20, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Mar 20, 2019 •
edited
Loading

Description

  • Change @fcoury's Key numbering from sequential Kxx to Kxy where x is the row number and y is the column number.
  • Add three additional layouts that correspond with the "supported" HB85 Layouts mentioned in the Group Buy. These layouts are stt, basic, and aop.
  • Add QMK Configurator support
  • Add notes on how to flash/reset eeprom

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin requested a review from drashna March 20, 2019 04:30
@drashna
Copy link
Member

drashna commented Mar 20, 2019

thanks!

@drashna drashna merged commit 995b31a into qmk:master Mar 20, 2019
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
@mechmerlin @chie4hao
[Keyboard] HB85 Refactor/Layout Addition (qmk#5451)
b3596ec 
* introduce stt layout with K(row)(col)

* set bootmagic to lite

* Rename the original LAYOUT to LAYOUT_all
Introduce the STT layout

In additional the whole matrix was changed to support the K(row)(col) notation.

* rename LAYOUT to LAYOUT_all

* add QMK Configurator support

* stt keymap based on mrpetrov's default configuration on the hb85 he lent me

* update readme

* introduce basic and aop layouts along with QMK Configurator support for them

* add a new line

* add EEP_RST to layer 1 as it is needed to get rgb underglow to work

* add documentation on how to reset the eeprom on the board

* put contributors names where appropriate
@mechmerlin mechmerlin deleted the feature/hb85_omg branch March 29, 2019 13:27
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 31, 2019
@mechmerlin @zer09
[Keyboard] HB85 Refactor/Layout Addition (qmk#5451)
cc75b33 
* introduce stt layout with K(row)(col)

* set bootmagic to lite

* Rename the original LAYOUT to LAYOUT_all
Introduce the STT layout

In additional the whole matrix was changed to support the K(row)(col) notation.

* rename LAYOUT to LAYOUT_all

* add QMK Configurator support

* stt keymap based on mrpetrov's default configuration on the hb85 he lent me

* update readme

* introduce basic and aop layouts along with QMK Configurator support for them

* add a new line

* add EEP_RST to layer 1 as it is needed to get rgb underglow to work

* add documentation on how to reset the eeprom on the board

* put contributors names where appropriate
danielo515 pushed a commit to danielo515/qmk_firmware that referenced this pull request May 15, 2019
@mechmerlin @danielo515
[Keyboard] HB85 Refactor/Layout Addition (qmk#5451)
c657f67 
* introduce stt layout with K(row)(col)

* set bootmagic to lite

* Rename the original LAYOUT to LAYOUT_all
Introduce the STT layout

In additional the whole matrix was changed to support the K(row)(col) notation.

* rename LAYOUT to LAYOUT_all

* add QMK Configurator support

* stt keymap based on mrpetrov's default configuration on the hb85 he lent me

* update readme

* introduce basic and aop layouts along with QMK Configurator support for them

* add a new line

* add EEP_RST to layer 1 as it is needed to get rgb underglow to work

* add documentation on how to reset the eeprom on the board

* put contributors names where appropriate
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@mechmerlin @Timbus
[Keyboard] HB85 Refactor/Layout Addition (qmk#5451)
d751c90 
* introduce stt layout with K(row)(col)

* set bootmagic to lite

* Rename the original LAYOUT to LAYOUT_all
Introduce the STT layout

In additional the whole matrix was changed to support the K(row)(col) notation.

* rename LAYOUT to LAYOUT_all

* add QMK Configurator support

* stt keymap based on mrpetrov's default configuration on the hb85 he lent me

* update readme

* introduce basic and aop layouts along with QMK Configurator support for them

* add a new line

* add EEP_RST to layer 1 as it is needed to get rgb underglow to work

* add documentation on how to reset the eeprom on the board

* put contributors names where appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcoury fcoury fcoury left review comments

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mechmerlin @drashna @fcoury