Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix a function signature #5313

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Docs: fix a function signature #5313

merged 1 commit into from
Mar 5, 2019

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Mar 5, 2019

The custom_quantum_functions docs currently read:

layer_state_set_* Function Documentation

  • Keyboard/Revision: void uint32_t layer_state_set_kb(uint32_t state)

void uint32_t is not a valid type, and I am inferring here that the correct type is uint32_t since that is what the _user function uses.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

`void uint32_t` is not a return type.
@drashna
Copy link
Member

drashna commented Mar 5, 2019

That would be correct, thanks!

@drashna drashna merged commit 4c62c7b into qmk:master Mar 5, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 7, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (76 commits)
  [Keyboard] Adds Gray Studio HB85 Initial Support (qmk#5311)
  [Keymap] Add KC_MAKE keycode to my userspace and keymaps (qmk#5324)
  [Keyboard] handwired/trackpoint: refactor and readme cleanup (qmk#5325)
  [Keyboard] re-arrange the pinout for backlight support (qmk#5321)
  [Keymap] update: simplify tapdance code for Minidox/keymaps/dustypomerleau (qmk#5315)
  [Keymap] Add vxid planck layout (qmk#5271)
  increase size of note counter variable to avoid overflow
  Adopted LAYOUT, added some keys (qmk#5320)
  Add more "decent" text editors (qmk#5308)
  Add DZ60 Tsangan Layout + Fn layer (qmk#5319)
  [Docs] Fix function signature (layer_state_set_*) (qmk#5313)
  Correct keyboard and layout dimensions for 40percent.club Foobar (qmk#5310)
  Dactyl Manuform 5x6, 5x7, and 6x6: QMK Configurator fixes and partial code clean-up (qmk#5307)
  Fixed default to dissable VIA (qmk#5309)
  Clean up debounce a bit (qmk#5255)
  Fix aanzee Configurator config file (qmk#5286)
  Separate keymaps to VIA enabled/dissabled. (qmk#5302)
  [Keymap] Add RGB config and controls to userspace (qmk#5299)
  Add LED Matrix to Features list for easy reference (qmk#5280)
  [Keymap] layout/community/ortho4x12/symbolic update (qmk#5274)
  ...
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 31, 2019
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants