Fix rgblight_enable ifdefs in my userspace #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mechmerlin
changed the title
bl1nk
added a commit
to bl1nk/qmk_firmware
that referenced
this pull request
Mar 3, 2019
* upstream/master: (58 commits) [Keymap] layout/community/ortho4x12/symbolic update (qmk#5274) [Keyboard] matrix_init_user shouldn't call itself (qmk#5298) [Keymap] Update keymap.c (qmk#5290) Update Atreus layout to match the Niu layout. Fix Niu comment typo. (qmk#5297) [Keymap] Fix comment in the KBD67 default keymap. (qmk#5296) [Keyboard] update Hecomi/alpha's info.json (qmk#5295) [Keyboard] Adding Numeric Keypad //e converter (qmk#5294) [Keyboard] Add support for matrix_scan_user to usb-usb converter (qmk#5291) handwired/terminus_mini: refactor, Configurator support, and readme cleanup (qmk#5292) [Keyboard] Initial commit for Prime_E w/ VIA config support (qmk#5285) [Keyboard] add dz60rgb ansi and hhkb support; add dz40rgb (qmk#5231) [Keyboard] Convert mf68_ble to keymap (qmk#5287) [Keymap] Added INSERT to my keymaps (qmk#5284) HS60 v2: Instructions how to reset and flash (qmk#5241) [Keymap] unausgeschlafen quefrency keymap (qmk#5273) [Keymap] Fix rgblight_enable ifdefs (qmk#5283) [Keymap] DCompact Layout Updates pt. 3 (qmk#5209) [Keyboard] Add Dozen0 (qmk#5272) [Keymap] update: add extrakey support for macOS media keys (qmk#5263) [Keymap] My TMO50 layout (qmk#5116) ...
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Mar 7, 2019
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Mar 18, 2019
chie4hao
pushed a commit
to chie4hao/qmk_firmware
that referenced
this pull request
Mar 28, 2019
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Apr 3, 2019
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like I broke some of the mechmerlin community layouts when it came to rgb lights. This should fix it by checking for RGBLIGHT_ENABLE before actually using
#define RGBLIGHT_ENABLE.Types of Changes
Issues Fixed or Closed by This PR
Checklist