Remove unnecessary IS_COMMAND definitions from a couple of boards #5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ac84b1
to
7c69522
Compare
|
@skullydazed Any issues with this? Just wanted to ping you, since it's your board. |
|
Bump. |
|
Thanks |
loadedsith
added a commit
to loadedsith/qmk_firmware
that referenced
this pull request
Mar 19, 2019
* master: (476 commits) [Keymap] Boy_314's Halfnhalf layout update (qmk#5441) [Keyboard] Remove unnecessary IS_COMMAND definitions from a couple of boards (qmk#5269) Cleanup Default Keymaps (qmk#5442) Fix dk60 compiler issue on newer compiler versions (qmk#5444) correct typo in eeprom split target for dfu (qmk#5445) [Docs] Recursively clone qmk_firmware repo (qmk#5378) [Docs] Smallish overhaul of the docs (qmk#5281) [Keyboard] Reduce compile size of the Lily58 Keyboard (qmk#5412) [Docs] Add music_map to audio documentation (qmk#5419) [Keymap] PyroL's TMO50 layout update (qmk#5435) [Keymap] Add vim-style keymap for lets split (qmk#5399) [Keyboard] CannonKeys Instant60 Keyboard (qmk#5433) [Keymap] add android studio keyboard shortcuts to dvorak 42 key atreus / ergodox layouts (qmk#5423) [Keymap] Updated layout after some months of testing. (qmk#5427) [Keyboard] Corrected layout for top row keys (qmk#5429) [Keyboard] Add Jot50 handwired board (qmk#5431) [Keyboard] layout fixed in jotanck.h (qmk#5432) [Keyboard] correct indicator light states (qmk#5434) [Keyboard] Fix matrix positions for HotDox (qmk#5437) [Keymap] Arkag Userspace Update (qmk#5438) ... # Conflicts: # keyboards/keebio/iris/rules.mk # layouts/community/ortho_4x12/grahampheath/keymap.c
chie4hao
pushed a commit
to chie4hao/qmk_firmware
that referenced
this pull request
Mar 28, 2019
… boards (qmk#5269) * Remove unnecessary IS_COMMAND definition from clueboard/66_hotswap/gen1 * Remove old-style IS_COMMAND definition comment from dozen0 * Use get_mods() instead of keyboard_report->mods in georgi
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Mar 31, 2019
… boards (qmk#5269) * Remove unnecessary IS_COMMAND definition from clueboard/66_hotswap/gen1 * Remove old-style IS_COMMAND definition comment from dozen0 * Use get_mods() instead of keyboard_report->mods in georgi
danielo515
pushed a commit
to danielo515/qmk_firmware
that referenced
this pull request
May 15, 2019
… boards (qmk#5269) * Remove unnecessary IS_COMMAND definition from clueboard/66_hotswap/gen1 * Remove old-style IS_COMMAND definition comment from dozen0 * Use get_mods() instead of keyboard_report->mods in georgi
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
… boards (qmk#5269) * Remove unnecessary IS_COMMAND definition from clueboard/66_hotswap/gen1 * Remove old-style IS_COMMAND definition comment from dozen0 * Use get_mods() instead of keyboard_report->mods in georgi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another few outdated
IS_COMMANDdefinitions that made it past code review. See #4301 #5065 for more information.