Travis CI - skip unit tests for documentation changes #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Feb 28, 2019
drashna
reviewed
Feb 28, 2019
mechmerlin
reviewed
Mar 4, 2019
|
@jackhumbert and @skullydazed Do you see any issues with this? |
skullydazed
approved these changes
Apr 19, 2019
|
Thanks! |
foosinn
pushed a commit
to foosinn/qmk_firmware
that referenced
this pull request
May 6, 2019
* Add script to skip tests on non master branches with only docs changes * Review comments - Use 'grep -c' instead of 'wc -l'
shimesaba-type0
pushed a commit
to shimesaba-type0/qmk_firmware
that referenced
this pull request
Jun 22, 2019
* Add script to skip tests on non master branches with only docs changes * Review comments - Use 'grep -c' instead of 'wc -l'
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
* Add script to skip tests on non master branches with only docs changes * Review comments - Use 'grep -c' instead of 'wc -l'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently unit tests take 35s, which if you have only changed docs is a waste of cpu cycles. Given the limit of 5 concurrent builds, any time saved helps to keep the build job backlog free.
This PR follows the ideas configured within
travis_build.shand sets up Travis to skip tests on non master branches with only docs changes.This could safely be extended to keyboard and community layout folders if required.
Types of Changes
Checklist