Added aeboards/aegis #5099
Added aeboards/aegis #5099
Conversation
| @@ -0,0 +1,68 @@ | |||
| # project specific files | |||
There was a problem hiding this comment.
@Wilba6582 Is it going to be customary for via keymaps to include the entire contents of the keyboard's rules.mk file?
There was a problem hiding this comment.
In theory, only this is necessary, as far as I'm aware:
BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration(+1000)
MOUSEKEY_ENABLE = no # Mouse keys(+4700)
EXTRAKEY_ENABLE = yes # Audio control and System control(+450)
CONSOLE_ENABLE = no # Console for debug(+400)
COMMAND_ENABLE = no # Commands for debug and configuration
# Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE
SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend
# if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work
NKRO_ENABLE = yes # USB Nkey Rollover
BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality on B7 by default
MIDI_ENABLE = no # MIDI support (+2400 to 4200, depending on config)
UNICODE_ENABLE = no # Unicode
BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID
AUDIO_ENABLE = no # Audio output on port C6
FAUXCLICKY_ENABLE = no # Use buzzer to emulate clicky switches
RAW_ENABLE = yes
DYNAMIC_KEYMAP_ENABLE = yes
SRC = keyboards/wilba_tech/wt_main.cThere was a problem hiding this comment.
Is there a specific reason for it, though?
It looks to be identical to the main rules.mk for the keyboard, so ... it's redundant.
There was a problem hiding this comment.
The specific reason is the same as the last time you asked me this exact same question:
It's a placeholder for me coming back to these and refactoring it down to the things that need to be explicitly set for VIA compatibility (esp. feature defines), not that it wouldn't work now as just the delta with the parent.
Also, the "via" keymap will build the same regardless of (most) end user edits in the parent rules.mk
Just because something is redundant doesn't automatically make it bad.
For now, while we're in this intermediate stage of VIA support being in a state of flux, can we be a little less pedantic about my commits?
* master: (179 commits) Updates to noroadsleft keymap for KC60 (qmk#5127) [Keymap] Update to Drashna keymaps and Userspace (qmk#5122) Fix ESC on Default ANSI layer (qmk#5125) [Keyboard] KBD19x Bootmagic Enable (lite) and other fixes (qmk#5126) [Keymap] Add fsck keymaps for eco, planck and preonic (qmk#5106) [Keyboard] Unigo66 beta pcb added, bug fixes for flashing (qmk#5108) [Keymap] Adding buhearns keymap (qmk#5105) [Keyboard] New Keyboard: Doro67 Regular PCB (qmk#5115) Add Satisfaction75 to QMK, Enable EEPROM on stm32f072 (qmk#5094) Fix travis_compiled_push.sh script issue (qmk#5114) [Keyboard] Added aeboards/aegis (qmk#5099) [Keyboard] Refactor jj4x4 to enable ortho_4x4 LAYOUT (qmk#5112) [Keyboard] Move Keebio boards to own folder (qmk#5109) [Keymap] Plain60 rgb (qmk#5104) [Keymap] Add Minidox keymap by dustypomerleau (qmk#5101) Remove AUTOGEN and fix Travis Compiled Push scripts (qmk#5077) Added WT75-A, refactor wilba.tech PCBs (qmk#5100) [Keyboard] Space65: RGB Animations on by default (qmk#5097) Add digital layout for KBD75 (qmk#5095) fix the led_matrix.h naming conflict ...
* Added aeboards/aegis * PR changes
Description
Added aeboards/aegis
Types of changes
Checklist: