Fix Ergodox EZ issues introduced with ShinyDox merge (#3229) #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackhumbert
approved these changes
Jul 9, 2018
|
Travis CI error is due to my keymap and how the secrets stuff is included. Can ignore (or merge my keymap PR :D) |
|
Thank you @drashna and @jackhumbert ! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables the RGBW and BitBang features for the RGB Underglow, as it breaks compiling if you want to enable RGB underglow rather than rgb matrix.
Also, defaults to RGB underglow, and NOT matrix (for now).
@ezuk This look good?
Fixes #3321